Skip to content

Proposal to change Unmanaged API to use UnsafePointer #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2015

Conversation

jtbandes
Copy link
Contributor

@jtbandes jtbandes commented Dec 9, 2015

@jtbandes jtbandes force-pushed the unmanaged branch 2 times, most recently from e89fff2 to f903953 Compare December 12, 2015 10:37

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
DougGregor added a commit that referenced this pull request Dec 18, 2015
Proposal to change Unmanaged API to use UnsafePointer
@DougGregor DougGregor merged commit 805c407 into swiftlang:master Dec 18, 2015
@jtbandes
Copy link
Contributor Author

@DougGregor Thanks for merging. However, @dabrahams's recent Unmanaged proposal may subsume this one. (I haven't read it yet, but will soon.)

@DougGregor
Copy link
Member

Ah, indeed. If it does "manage" to subsume this one (har har), we'll just mark this as subsumed. It looks like @dabrahams proposal still uses COpaquePointer.

@dabrahams
Copy link

Largely because we can’t give just UnsafePointer<Void> an init taking an UnsafeReference. But I have a larger concern that pointers to Void and incomplete types are not in any sense “unsafe” (once you restrict the interface as appropriate for incomplete types), and so maybe we want OpaquePointer<T> for these.

@gribozavr
Copy link
Contributor

@dabrahams We can, if we use a protocol extension (we'd need to introduce a throwaway protocol though).

@dabrahams
Copy link

@gribozavr Oh, yes, that's an evil hack.

@jtbandes jtbandes deleted the unmanaged branch July 19, 2016 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants