New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "bpo-" in Misc/NEWS #1
Conversation
Doc/tools/extensions/pyspecific.py
Outdated
@@ -253,7 +253,7 @@ def run(self): | |||
text = 'The NEWS file is not available.' | |||
node = nodes.strong(text, text) | |||
return [node] | |||
content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__', | |||
content = issue_re.sub(r'`\bpo-\2 <https://bugs.python.org/\2>`__', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\b
? I think you overwrote the \1
:-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's on purpose as the first capture group is the prefix which doesn't matter. Probably should change the regex to use a non-capture group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, you can either you use \1
or insert bpo-
. But here you overwrote half the capture group by only deleting the 1
and not the \
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right. Now fixed.
Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.
Doc/tools/extensions/pyspecific.py
Outdated
@@ -34,7 +34,7 @@ | |||
|
|||
|
|||
ISSUE_URI = 'https://bugs.python.org/issue%s' | |||
SOURCE_URI = 'https://hg.python.org/cpython/file/3.6/%s' | |||
SOURCE_URI = 'https://github.com/python/cpython/tree/3.6/%s' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be master
rather than 3.6
on this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My patch for another issue will address this, I think 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and updated here since I'm already changing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok :)
Doc/tools/extensions/pyspecific.py
Outdated
@@ -253,7 +253,7 @@ def run(self): | |||
text = 'The NEWS file is not available.' | |||
node = nodes.strong(text, text) | |||
return [node] | |||
content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__', | |||
content = issue_re.sub(r'`bpo-\1 <https://bugs.python.org/\1>`__', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest making it https://bugs.python.org/issue\1
to avoid the redirect through https://www.python.org/sf/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
(cherry picked from commit 79ab8be)
Change the url to 3.5 (cherry picked from commit 79ab8be) # Conflicts: # Doc/tools/extensions/pyspecific.py
Change the url to 2.7 (cherry picked from commit 79ab8be)
* Added support for CAN_ISOTP protocol * Added unit tests for CAN ISOTP * Updated documentation for ISO-TP protocol * Removed trailing whitespace in documentation * Added blurb NEWS.d file * updated Misc/ACKS * Fixed broken unit test that was using isotp const outside of skippable section * Removed dependecy over third party project * Added implementation for getsockname + unit tests * Missing newline at end of ACKS file * Accidentally inserted a type in ACKS file * Followed tiran changes review #1 recommendations * Added spaces after comma
* Added support for CAN_ISOTP protocol * Added unit tests for CAN ISOTP * Updated documentation for ISO-TP protocol * Removed trailing whitespace in documentation * Added blurb NEWS.d file * updated Misc/ACKS * Fixed broken unit test that was using isotp const outside of skippable section * Removed dependecy over third party project * Added implementation for getsockname + unit tests * Missing newline at end of ACKS file * Accidentally inserted a type in ACKS file * Followed tiran changes review #1 recommendations * Added spaces after comma
Restoring the original shar contents
Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, @Mariatta, I could not cleanly backport this to
|
Hijacked the interpreter state to get my boys on the inside. Currently, there doesn't seem to be an officially supported way to get a piece of pre-initialized per-interpreter memory over to an embedded module (more specifically, the embedded module's functions). For example: [init'd mem python#1] ----> [subinterp python#1] ----> {module fn call} [init'd mem python#2] ----> [subinterp python#2] ----> {module fn call} {module fn call} has a single implementation with access to its module state via \`PyModule_GetState\`. The initialization of a subinterpreter populates a custom entry for the pre-initialized memory in its interpreter state. On initialization of the embedded module (\`Py_mod_exec\`), the module state is populated with the custom entry (\`PyThreadState_Get()->interp\`). The module function now has access to the pre-initialized memory via its module state.
Hijacked the interpreter state to get my boys on the inside. Currently, there doesn't seem to be an officially supported way to get a piece of pre-initialized per-interpreter memory over to an embedded module (more specifically, the embedded module's functions). For example: [init'd mem python#1] ----> [subinterp python#1] ----> {module fn call} [init'd mem python#2] ----> [subinterp python#2] ----> {module fn call} {module fn call} has a single implementation with access to its module state via `PyModule_GetState`. The initialization of a subinterpreter populates a custom entry for the pre-initialized memory in its interpreter state. On initialization of the embedded module (`Py_mod_exec`), the module state is populated with the custom entry (`PyThreadState_Get()->interp`). The module function now has access to the pre-initialized memory via its module state.
Bumps [importlib-resources](https://github.com/python/importlib_resources) from 6.1.2 to 6.4.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/python/importlib_resources/blob/main/NEWS.rst">importlib-resources's changelog</a>.</em></p> <blockquote> <h1>v6.4.0</h1> <h2>Features</h2> <ul> <li>The functions <code>is_resource()</code>, <code>open_binary()</code>, <code>open_text()</code>, <code>path()</code>, <code>read_binary()</code>, and <code>read_text()</code> are un-deprecated, and support subdirectories via multiple positional arguments. The <code>contents()</code> function also allows subdirectories, but remains deprecated. (<a href="https://redirect.github.com/python/importlib_resources/issues/303">#303</a>)</li> <li><code>python/cpython#109829</code></li> </ul> <h1>v6.3.2</h1> <h2>Bugfixes</h2> <ul> <li>Restored expectation that local standard readers are preferred over degenerate readers. (<a href="https://redirect.github.com/python/importlib_resources/issues/298">#298</a>)</li> </ul> <h1>v6.3.1</h1> <h2>Bugfixes</h2> <ul> <li>Restored expectation that stdlib readers are suppressed on Python 3.10. (<a href="https://redirect.github.com/python/importlib_resources/issues/257">#257</a>)</li> </ul> <h1>v6.3.0</h1> <h2>Features</h2> <ul> <li>Add <code>Anchor</code> to <code>importlib.resources</code> (in order for the code to comply with the documentation)</li> </ul> <h1>v6.2.0</h1> <p>Features</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/python/importlib_resources/commit/1f4d3f10a3ed5d65b3092a39369c08e71e30a97c"><code>1f4d3f1</code></a> Finalize</li> <li><a href="https://github.com/python/importlib_resources/commit/c593cd9cb03f69bd2348267cfc6851b75ea5e08b"><code>c593cd9</code></a> Merge pull request <a href="https://redirect.github.com/python/importlib_resources/issues/303">#303</a> from encukou/functional</li> <li><a href="https://github.com/python/importlib_resources/commit/fa60969a37ed01302d2ed01956e8ef18eba87923"><code>fa60969</code></a> Add news fragment.</li> <li><a href="https://github.com/python/importlib_resources/commit/ca03a4df06b8794810ad5c4d34265d40fb4b3f49"><code>ca03a4d</code></a> <a href="https://redirect.github.com/python/importlib_resources/issues/109653">GH-109653</a>: Defer import of <code>importlib.metadata._adapters</code><code>python/cpython#1</code></li> <li><a href="https://github.com/python/importlib_resources/commit/2df6ced9be7d45cdc443ceb8c7e66ab846d19ebc"><code>2df6ced</code></a> Use Ruff style, rather than PEP 8</li> <li><a href="https://github.com/python/importlib_resources/commit/8fdadde235ce5d5d8f80934bb2f9c9b29cb0da78"><code>8fdadde</code></a> Port tests to Python 3.8</li> <li><a href="https://github.com/python/importlib_resources/commit/558f5bf9f266998e616deaf8a9d373da37b33054"><code>558f5bf</code></a> Formatting nitpicks</li> <li><a href="https://github.com/python/importlib_resources/commit/1e98e351779d53092d7988d362503b54b3dc6b35"><code>1e98e35</code></a> Adapt to importlib_resources</li> <li><a href="https://github.com/python/importlib_resources/commit/189d15fcbe99a1ec624fb19992544096e2a538f3"><code>189d15f</code></a> Apply CPython PR, sans docs and changelogs</li> <li><a href="https://github.com/python/importlib_resources/commit/0db550c38ad9ba4ab4fb6fa8c070c040935e2f33"><code>0db550c</code></a> Consolidated test support logic in jaraco.test.cpython.</li> <li>Additional commits viewable in <a href="https://github.com/python/importlib_resources/compare/v6.1.2...v6.4.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=importlib-resources&package-manager=pip&previous-version=6.1.2&new-version=6.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
No description provided.