Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for Kotlin KClass parameter in SpringApplication.run() #8511

Closed
sdeleuze opened this issue Mar 6, 2017 · 4 comments
Closed

Provide support for Kotlin KClass parameter in SpringApplication.run() #8511

sdeleuze opened this issue Mar 6, 2017 · 4 comments
Labels
status: superseded An issue that has been superseded by another

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Mar 6, 2017

It would be nice to support natively Kotlin KClass parameter to allow writing SpringApplication.run(FooApplication::class, *args) in Spring Boot 2.0.

I could be implemented using classpath detection, would avoid java.lang.IllegalArgumentException: Invalid source type class kotlin.reflect.jvm.internal.KClassImpl error that Kotlin users get by default and would provide more idomatic Kotlin code than the current SpringApplication.run(FooApplication::class.java, *args).
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 6, 2017
@philwebb
Copy link
Member

philwebb commented Mar 6, 2017

Kotlin support would align nicely with Spring 5.0

@philwebb philwebb added priority: normal type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 6, 2017
@philwebb philwebb added this to the 2.0.0.M5 milestone Mar 6, 2017
@philwebb philwebb modified the milestones: 2.0.0.M5, 2.0.0.RC2, 2.0.0.RC1 Sep 20, 2017
@sdeleuze
Copy link
Contributor Author

sdeleuze commented Oct 2, 2017

I have started to work on this.

@sdeleuze sdeleuze mentioned this issue Oct 4, 2017
Closed
@sdeleuze
Copy link
Contributor Author

sdeleuze commented Oct 4, 2017

Pull request submitted.

@snicoll
Copy link
Member

snicoll commented Oct 7, 2017

Closing in favour of PR #10511

@snicoll snicoll closed this as completed Oct 7, 2017
@snicoll snicoll added status: duplicate A duplicate of another issue and removed priority: normal type: enhancement A general enhancement labels Oct 7, 2017
@snicoll snicoll removed this from the 2.0.0.RC1 milestone Oct 7, 2017
@philwebb philwebb added status: superseded An issue that has been superseded by another and removed status: duplicate A duplicate of another issue labels Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sdeleuze @snicoll @philwebb @spring-projects-issues