Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New topic information isn't picked up until restart #250

Closed
jiminoc opened this issue Sep 27, 2017 · 3 comments
Closed

New topic information isn't picked up until restart #250

jiminoc opened this issue Sep 27, 2017 · 3 comments

Comments

@jiminoc
Copy link
Contributor

jiminoc commented Sep 27, 2017 •
edited

Burrow does not seem to pick up changes to partitions in a topic until it's restarted.

Steps:

  1. clone latest burrow from github (go get)
  2. Start burrow up with default configs (changed broker/zk hosts)
  3. http://localhost:8000/v2/kafka/local/topic to show my test topic "test.jim1" does not appear
  4. create a topic in kafka called "test.jim1" with 1 partition
  5. change meta refresh interval to 30 seconds to force faster refresh of client.Topics call
  6. webpage shows 1 partition
  7. add partition to topic
  8. describe topics on kafka shows 2 partitions, after several metadata refreshes burrow still shows 1 partition
  9. on burrow restart, both partitions are now reflected.

Is this a regression or?
Figured I'd ask before digging into the code.

*updated, new topics works after the meta refresh internal, documenting partition refresh still doesn't
@jiminoc
Copy link
Contributor Author

jiminoc commented Sep 27, 2017

found it, PR coming

@jiminoc jiminoc mentioned this issue Sep 27, 2017
Merged
toddpalino pushed a commit that referenced this issue Sep 28, 2017
@jiminoc @toddpalino
The addBrokerOffset function was attempting to handle expanding parti…
9476d6e 
…tion counts in the topicList however, changes weren't reflected on the next update. So if you added more partitions to a topic they wouldn't show up. refrences #250 (#251)
@toddpalino
Copy link
Contributor

Resolved by #251

@DavidLiuXh
Copy link

DavidLiuXh commented Nov 29, 2017 •
edited

Also need to do the same thing for addConsumerOffset function

if int(offset.Partition) >= len(consumerTopicMap) {
		// The partition count must have increased. Append enough extra partitions to our slice
		for i := len(consumerTopicMap); i < partitionCount; i++ {
			consumerTopicMap = append(consumerTopicMap, nil)
		}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jiminoc @toddpalino @DavidLiuXh