Skip to content

writes multiinstance_sequential:'Yes' in JSON output #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2014
Merged

writes multiinstance_sequential:'Yes' in JSON output #464

merged 1 commit into from
Dec 9, 2014

Conversation

bluejoe2008
Copy link
Contributor

the old BaseBpmnJsonConverter.convertToJson() does not write 'multiinstance_sequential' property when the value is 'true', which causes JsonConverterUtil.getPropertyValueAsBoolean(PROPERTY_MULTIINSTANCE_SEQUENTIAL, elementNode) returns default value 'false' in BaseBpmnJsonConverter.convertToBpmnModel() method:

  public static boolean getPropertyValueAsBoolean(String name, JsonNode objectNode, boolean defaultValue) {
    boolean result = defaultValue;
    String stringValue = getPropertyValueAsString(name, objectNode);

    if (PROPERTY_VALUE_YES.equalsIgnoreCase(stringValue)) {
      result = true;
    } else if (PROPERTY_VALUE_NO.equalsIgnoreCase(stringValue)) {
      result = false;
    }

    return result;
  }

@tijsrademakers tijsrademakers merged commit e35292e into Activiti:master Dec 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants