Feature - Moving SessionDelegate to Store Requests #1391
Merged
+40
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| taskDelegateLock.lock() ; defer { taskDelegateLock.unlock() } | ||
| taskDelegate = newValue | ||
| } | ||
| } |
There was a problem hiding this comment.
This may be overkill to wrap the change here in a lock, but I figure it's better safe than sorry. The only time this can ever change is when a data task is converted to a download task. Previously we were changing the subdelegate and not actually updating the request. That then created a mismatch between what the Request delegate reported and what was actually called.
There was a problem hiding this comment.
If we decide this is unnecessary, then it's really simple. We just need to remove the taskDelegate and the taskDelegateLock and revert this change while maintaining the internal(set) var delegate change.
|
👍 Feel free to merge. |
|
Awesome...thanks @jshier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
SessionDelegateto storeRequests internally instead of only the task delegates of theRequestin preparation for more advanced features such as retry logic.