Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Podfile.lock files between Ruby versions #3452

Closed
cbrauchli opened this issue Apr 23, 2015 · 8 comments
Closed

Inconsistent Podfile.lock files between Ruby versions #3452

cbrauchli opened this issue Apr 23, 2015 · 8 comments
Assignees
Labels
s2:confirmed Issues that have been confirmed by a CocoaPods contributor t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!

Comments

@cbrauchli
Copy link
Contributor

馃寛

It looks like the Podfile.lock has different path strings for development pods depending on which version of Ruby is being used.

On Ruby 2.2.2:

EXTERNAL SOURCES:
  MobileShared:
    :path: "./mobile-iphone-shared"

On Ruby 2.0.0:

EXTERNAL SOURCES:
  MobileShared:
    :path: ./mobile-iphone-shared
@segiddins segiddins self-assigned this Apr 23, 2015
@segiddins segiddins added t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! s2:confirmed Issues that have been confirmed by a CocoaPods contributor labels Apr 23, 2015
@segiddins
Copy link
Member

So, this is happening because I'm using Psych to encode strings before they get into the lockfile, and I think the inconsistency is coming for psych. I'm really not sure what we can do about this.

@segiddins
Copy link
Member

I opened an issue on Psych at ruby/psych#232, but I think I can do something to avoid re-writing the file if the contents is, other than the quoting difference, exactly the same. It won't save you from irrelevant diff lines, but it could mean that pod install can avoid dirtying your git status. Would that be worth doing?

@cbrauchli
Copy link
Contributor Author

@segiddins I think so. People not familiar with the Podfile.lock might assume that they've done something wrong to change it.

Also, thanks for filing the psych issue!

@segiddins
Copy link
Member

@cbrauchli in that case, CocoaPods/Core@5133472 should help! It won't save you from longer diffs, but it will hopefully mean that, when the semantic contents of the lockfile haven't changed, the file won't change the quotes.

@cbrauchli
Copy link
Contributor Author

Works for me! Is there any chance this change will make it onto the 0.36 branch or will we have to wait for 0.37?

@segiddins
Copy link
Member

I don't know if we'll have another 0.36 release, since releases take a few hours, but that's probably @kylef's call.

@cbrauchli
Copy link
Contributor Author

This is till happening in 0.37.1 and I noticed ruby/psych#232 is closed as invalid. Can we expect a long-term fix in CocoaPods or is the solution to get everyone on the same Ruby version?

@segiddins
Copy link
Member

It's not really a problem CocoaPods can fix, unfortunately. Both are valid YAML files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s2:confirmed Issues that have been confirmed by a CocoaPods contributor t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Development

No branches or pull requests

2 participants