proxy and backend connecition support both single & multi connections #1007
+56
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你的patch。2.0作为稳定分支，只修bug，而且可能会在短期内EOL。3.0也属于稳定分支，也不太适合加feature，请提交到3.1分支上，谢谢！ |
|
OK，get it ,thx |
|
@left2right 有 1024 个 slot，这么修改的话，最后会导致 backend 连接数过大 1024 x |codis-server|，并且每个 backend conn 会产生两个 routine 分别用于读写，所以我还是不太建议这么修改。 之前我有一个解决方案，一直没有提交过，因为在 redis 下面多连接性能损失会比较大，但是如果后端是 rocksdb 的确结论会不太一样。你可以切到 redis3.2 branch 下看一下。不过这个 branch 后面有空的话应该会 merge 到 release3.1。 谢谢～ |
|
@spinlock 多谢你的回复，及在release 3.1上支持多连接 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we know, codis proxy and backend server(redis) use one connection, this works well on fast redis, however if we want to use some disk nosql database which is not that fast(eg ssdb or pika) as backend server, the performance descend a lot.
Disk database could store more data than memory database, it is used a lot in many companies.
This PR support codis 2.0 could be configured both multi and single connection between proxy and backend server.