looks good to me, hopefully it can be merged and a new build done

I just commented on the original ticket. This doesn't actually work as intended, the date time picker pop up is blank. Will cancel and investigate further.

ah okay :(

Ugh, it was my own environmental issues. Going through an upgrade and had some old CSS leaking through that prevented the calendar picker from displaying.

Re-opening, sorry for that.

least it works thats all that matters, good work, not sure how you get it signed off to be deployed

@Eonasdan can this be scheduled for a merge

Hi @Eonasdan, this fixes an issue where jQuery 3.0 was not supported. I just read your contributing guide, please let me know if you wish me to switch this PR to the development branch.

As an aside, what is the release schedule? We depend on this project via NPM and it looks like a release hasn't occurred since 2015.

Regards,
T

@tsneed290 i think the pull request needs to point to development not master

Very important notes

Pull requests to the master branch will be closed. Please submit all pull requests to the development >branch.
Do not include the minified files in your pull request. Don't worry, we'll build them when we cut a >release.
Pull requests that do not include a description (title only) and the following will be closed:
What the change does
A use case (for new features or enhancements)

Thanks @steveyj79, will move it.

@steveyj79 it looks like the development branch has the fixes needed to support jQuery 3.

While not desired, I am able to depend on the project in my package.json by referencing the git commit hash:

 "dependencies": {
    "eonasdan-bootstrap-datetimepicker": "git://github.com/Eonasdan/bootstrap-datetimepicker.git#d4971777a957d1d3134b1d90a695a3169111f65f",
  }

@Eonasdan When do you think you'll be releasing 4.17.42 to NPM's registry?

dev is now master and updated in npm

Cheers @Eonasdan

Thanks @Eonasdan!!

@Eonasdan, since this is a hotfix, could you please replace the buggy one currently at NuGet?

Can this be updated in bower please? bower still shows and pushes version 4.17.37 as the latest which uses input.size.

Wouldn't creating a 4.17.42 tag solve the issue with bower which @ramin25 mentioned?

@Eonasdan or @nikoskalogridis can one of you guys please create a new tag so we can get the changes via bower?

@tsneed290

Ugh, it was my own environmental issues. Going through an upgrade and had some old CSS leaking through that prevented the calendar picker from displaying.

This actually appears to be a real issue in jQuery 3.1 that has been reported here #1765.

For bower users who are not aware, there is version 4.17.45 which works.