Skip to content

Release alpha version for 3.0 alphas #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JakeWharton opened this issue Jul 1, 2017 · 11 comments
Closed

Release alpha version for 3.0 alphas #999

JakeWharton opened this issue Jul 1, 2017 · 11 comments
Milestone
9.0.0

Comments

@JakeWharton
Copy link
Owner

With proper feature plugin support
@c2c2
Copy link

c2c2 commented Jul 7, 2017

I want use in feature plugin but show an error:
Attribute value must be constant
and i can't use it

@elodieferrais
Copy link

I faced the error mentioned in this issue 963.
I am now using a forked version of the repo.
The main changes are:

I don't see the error mentioned in the issue #963 anymore but it still doesn't assemble.
The error I see is

error: cannot find symbol
import com.elodieferrais.myapp.R2;
symbol: class R2
location: package com.elodieferrais.myapp

What I don't understand is that I see the R2 file being generated but for some reason the java class doesn't pick it up...
Like it has been generated but too late maybe... ¯_(ツ)_/¯

I created a sample app where I reproduced the error: https://github.com/elodieferrais/ButterknifeSample

The title and comment of this ticket seemed to be similar to the problem I am facing, did you create it to fix an issue like this one?

@SmallerRiver
Copy link

I added all the dependencies but there were errors
Error:(2,0) Cannot add extension with name "buildOutputs" ,as there is an extension already registered with that name
I use AS3.0 canary 4

@Yuliya-Kaleda
Copy link

AS 3.0 Canary 5
Butterknife 8.7.0

Caused by: java.lang.NoSuchMethodError: com.android.build.gradle.api.BaseVariant.getOutputs()Ljava/util/List;
        at butterknife.plugin.ButterKnifePlugin$applyPlugin$1.execute(ButterKnifePlugin.kt:27)
        at butterknife.plugin.ButterKnifePlugin$applyPlugin$1.execute(ButterKnifePlugin.kt:15)
        at org.gradle.internal.ImmutableActionSet$CompositeSet.execute(ImmutableActionSet.java:196)
        at org.gradle.internal.MutableActionSet.execute(MutableActionSet.java:35)
        at org.gradle.api.internal.DefaultDomainObjectCollection.doAdd(DefaultDomainObjectCollection.java:204)
        at org.gradle.api.internal.DefaultDomainObjectCollection.add(DefaultDomainObjectCollection.java:198)
        at com.android.build.gradle.LibraryExtension.addVariant(LibraryExtension.java:70)
        at com.android.build.gradle.FeatureExtension.addVariant(FeatureExtension.java:80)
        at com.android.build.gradle.internal.ApiObjectFactory.create(ApiObjectFactory.java:137)
        at com.android.build.gradle.BasePlugin.lambda$createAndroidTasks$8(BasePlugin.java:625)
        at com.android.builder.profile.ThreadRecorder.record(ThreadRecorder.java:81)
        at com.android.build.gradle.BasePlugin.createAndroidTasks(BasePlugin.java:610)
        at com.android.build.gradle.BasePlugin.lambda$null$6(BasePlugin.java:537)
        at com.android.builder.profile.ThreadRecorder.record(ThreadRecorder.java:81)
        at com.android.build.gradle.BasePlugin.lambda$createTasks$7(BasePlugin.java:533)
        at org.gradle.internal.event.BroadcastDispatch$ActionInvocationHandler.dispatch(BroadcastDispatch.java:91)
        at org.gradle.internal.event.BroadcastDispatch$ActionInvocationHandler.dispatch(BroadcastDispatch.java:80)
        at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:42)
        at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:230)
        at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:149)
        at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:58)
        ... 90 more

@elodieferrais
Copy link

@Yuliya-Kaleda The stacktrace you posted is related to the issue 963 I believe.

@Yuliya-Kaleda
Copy link

@elodieferrais it is. You added a link from 963 to this issue. So I am posting here to inform that feature plugin is not fully supported.

@diswy
Copy link

diswy commented Jul 17, 2017

use 8.5.1 can work it.

@jaredsburrows
Copy link
Contributor

jaredsburrows commented Aug 13, 2017 •
edited
Loading

@JakeWharton You can close this now as you have 9.0.0-SNAPSHOT released using AGP 3.0.0-alpha9.

@phileo
Copy link

phileo commented Sep 1, 2017

Is support for "api" and "implementation" separation to replace "compile" within scope of this request?
https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_separation

@JakeWharton JakeWharton added this to the 9.0.0 milestone Oct 11, 2017
@Zkffkah
Copy link

Zkffkah commented Nov 10, 2017

Since AS 3.0 becomes stable, when migrating our project to AS 3.0, can we use 9.0.0-SNAPSHOT in production, is it stable enough? If not, can we have a stable mid version before 9.0.0 release. Thanks

@p-fischer
Copy link

This issue is resolved with the release of 9.0.0-rc1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
10 participants
@JakeWharton @phileo @jaredsburrows @elodieferrais @c2c2 @Zkffkah @p-fischer @Yuliya-Kaleda @diswy @SmallerRiver