Skip to content

Release alpha version for 3.0 alphas #999

New issue
New issue
Closed
Closed
Release alpha version for 3.0 alphas#999
Milestone
9.0.0
@JakeWharton

Description

@JakeWharton
JakeWharton
opened on Jul 1, 2017
Owner

With proper feature plugin support

Activity

c2c2

c2c2 commented on Jul 7, 2017

@c2c2
c2c2
on Jul 7, 2017

I want use in feature plugin but show an error:
Attribute value must be constant
and i can't use it

elodieferrais

elodieferrais commented on Jul 7, 2017

@elodieferrais
elodieferrais
on Jul 7, 2017

I faced the error mentioned in this issue 963.
I am now using a forked version of the repo.
The main changes are:

I don't see the error mentioned in the issue #963 anymore but it still doesn't assemble.
The error I see is

error: cannot find symbol
import com.elodieferrais.myapp.R2;
symbol: class R2
location: package com.elodieferrais.myapp

What I don't understand is that I see the R2 file being generated but for some reason the java class doesn't pick it up...
Like it has been generated but too late maybe... ¯_(ツ)_/¯

I created a sample app where I reproduced the error: https://github.com/elodieferrais/ButterknifeSample

The title and comment of this ticket seemed to be similar to the problem I am facing, did you create it to fix an issue like this one?

SmallerRiver

SmallerRiver commented on Jul 10, 2017

@SmallerRiver
SmallerRiver
on Jul 10, 2017

I added all the dependencies but there were errors
Error:(2,0) Cannot add extension with name "buildOutputs" ,as there is an extension already registered with that name
I use AS3.0 canary 4

Yuliya-Kaleda

Yuliya-Kaleda commented on Jul 10, 2017

@Yuliya-Kaleda
Yuliya-Kaleda
on Jul 10, 2017

AS 3.0 Canary 5
Butterknife 8.7.0

Caused by: java.lang.NoSuchMethodError: com.android.build.gradle.api.BaseVariant.getOutputs()Ljava/util/List;
        at butterknife.plugin.ButterKnifePlugin$applyPlugin$1.execute(ButterKnifePlugin.kt:27)
        at butterknife.plugin.ButterKnifePlugin$applyPlugin$1.execute(ButterKnifePlugin.kt:15)
        at org.gradle.internal.ImmutableActionSet$CompositeSet.execute(ImmutableActionSet.java:196)
        at org.gradle.internal.MutableActionSet.execute(MutableActionSet.java:35)
        at org.gradle.api.internal.DefaultDomainObjectCollection.doAdd(DefaultDomainObjectCollection.java:204)
        at org.gradle.api.internal.DefaultDomainObjectCollection.add(DefaultDomainObjectCollection.java:198)
        at com.android.build.gradle.LibraryExtension.addVariant(LibraryExtension.java:70)
        at com.android.build.gradle.FeatureExtension.addVariant(FeatureExtension.java:80)
        at com.android.build.gradle.internal.ApiObjectFactory.create(ApiObjectFactory.java:137)
        at com.android.build.gradle.BasePlugin.lambda$createAndroidTasks$8(BasePlugin.java:625)
        at com.android.builder.profile.ThreadRecorder.record(ThreadRecorder.java:81)
        at com.android.build.gradle.BasePlugin.createAndroidTasks(BasePlugin.java:610)
        at com.android.build.gradle.BasePlugin.lambda$null$6(BasePlugin.java:537)
        at com.android.builder.profile.ThreadRecorder.record(ThreadRecorder.java:81)
        at com.android.build.gradle.BasePlugin.lambda$createTasks$7(BasePlugin.java:533)
        at org.gradle.internal.event.BroadcastDispatch$ActionInvocationHandler.dispatch(BroadcastDispatch.java:91)
        at org.gradle.internal.event.BroadcastDispatch$ActionInvocationHandler.dispatch(BroadcastDispatch.java:80)
        at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:42)
        at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:230)
        at org.gradle.internal.event.BroadcastDispatch$SingletonDispatch.dispatch(BroadcastDispatch.java:149)
        at org.gradle.internal.event.AbstractBroadcastDispatch.dispatch(AbstractBroadcastDispatch.java:58)
        ... 90 more
elodieferrais

elodieferrais commented on Jul 10, 2017

@elodieferrais
elodieferrais
on Jul 10, 2017

@Yuliya-Kaleda The stacktrace you posted is related to the issue 963 I believe.

Yuliya-Kaleda

Yuliya-Kaleda commented on Jul 11, 2017

@Yuliya-Kaleda
Yuliya-Kaleda
on Jul 11, 2017

@elodieferrais it is. You added a link from 963 to this issue. So I am posting here to inform that feature plugin is not fully supported.

diswy

diswy commented on Jul 17, 2017

@diswy
diswy
on Jul 17, 2017

use 8.5.1 can work it.

jaredsburrows

jaredsburrows commented on Aug 13, 2017

@jaredsburrows
jaredsburrows
on Aug 13, 2017 · edited by jaredsburrows
Contributor

@JakeWharton You can close this now as you have 9.0.0-SNAPSHOT released using AGP 3.0.0-alpha9.

phileo

phileo commented on Sep 1, 2017

@phileo
phileo
on Sep 1, 2017

Is support for "api" and "implementation" separation to replace "compile" within scope of this request?
https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_separation

JakeWharton
added this to the 9.0.0 milestone on Oct 11, 2017
Zkffkah

Zkffkah commented on Nov 10, 2017

@Zkffkah
Zkffkah
on Nov 10, 2017

Since AS 3.0 becomes stable, when migrating our project to AS 3.0, can we use 9.0.0-SNAPSHOT in production, is it stable enough? If not, can we have a stable mid version before 9.0.0 release. Thanks

p-fischer

p-fischer commented on Oct 12, 2018

@p-fischer
p-fischer
on Oct 12, 2018

This issue is resolved with the release of 9.0.0-rc1.

JakeWharton
closed this as completedon Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @JakeWharton@phileo@jaredsburrows@elodieferrais@c2c2

        Issue actions
          Release alpha version for 3.0 alphas · Issue #999 · JakeWharton/butterknife