Skip to content

Add support for apns-collapse-id #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

onevcat
Copy link

@onevcat onevcat commented Aug 5, 2016

As mentioned in #51, I added support for apns-collapse-id.

For back compatibility, I added a new method containing collapseId as a parameter in SBAPNS, while keeping the original one. It should not be necessary. If you'd like, I could remove it with another commit.

@blommegard
Copy link
Member

blommegard commented Aug 5, 2016

Thanks for the PR!
I actually had a look at this yesterday, it would be great to repopulate the field after a successful push have been made. Somehow we need to be able to display / input an original ID at least.

What do you think about that?

@onevcat
Copy link
Author

onevcat commented Aug 5, 2016

@blommegard Wow, it will be cool to have a result box (or panel, or something could visually feedback) to show the result.

I think it's a good idea, but I am not sure in which way you want it. So I am afraid it's hard for me to help on it.

@ynot16
Copy link

ynot16 commented Sep 30, 2016

em....I wonder if it has supported the apns-collapse-id key?

@ajaybeniwal
Copy link

Any plans to merge this branch because i also waiting for apns-collapse-id key for request identification

@DavidSpringhetti
Copy link

I am also waiting for apns-collapse-id to keep from spamming my clients notifications when the same conversation is updated multiple times in a short period of time. Thanks.

@blommegard blommegard force-pushed the develop branch 2 times, most recently from dd897fc to 4e6392a Compare February 4, 2017 20:34
@aman46
Copy link

aman46 commented Sep 11, 2017

can apns-collapse-id merge both local and remote notification of same id ?

@aman46
Copy link

aman46 commented Sep 11, 2017

can collapse id merge local and remote notification of same id ?

@blommegard
Copy link
Member

This feature is now merged! #70

@blommegard blommegard closed this Sep 26, 2017
@blommegard
Copy link
Member

@aman46 That I don't know to be honest. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants