WASM: Fast array implementation #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cellule
force-pushed
the
wasm/fastarray
branch
2 times, most recently
from
545a333
to
4f3a702
Compare
|
@Krovatkin @commonlisp @arunetm You guys might be interested in this |
Cellule
commented
Jan 27, 2017
lib/Runtime/Library/ArrayBuffer.cpp
Outdated
| { | ||
| if (newBufferLength == this->bufferLength) | ||
| { | ||
| return this; |
There was a problem hiding this comment.
@MikeHolman I don't fully understand the spec for TransferInternal.
Must I always return a new ArrayBuffer or returning the current one is valid if the buffer doesn't change ?
There was a problem hiding this comment.
Yes, it should always return a new ArrayBuffer
|
@Cellule we are very much so! Thank you very much for a heads-up. We have high hopes that this change will improve some benchmark numbers 🎆 |
|
ping |
Create WebAssemblyArrayBuffer that forces to use VirtualAlloc on x64 Windows
Change the type of config flag for WasmFastArray
Cellule
force-pushed
the
wasm/fastarray
branch
from
847d3a2
to
2c70ea6
Compare
MikeHolman
reviewed
Feb 16, 2017
| { | ||
| return false; | ||
| if (isAsmJs) |
There was a problem hiding this comment.
i think we should make it more clear that this also will include wasm, e.g. by renaming this var
MikeHolman
reviewed
Feb 16, 2017
| } | ||
| else if (isWasm) | ||
| { | ||
| JavascriptError::ThrowWebAssemblyRuntimeError(func->GetScriptContext(), JSERR_InvalidTypedArrayIndex); |
There was a problem hiding this comment.
gotta say, i'm kind of amazed that this "just works"
|
|
Cellule
force-pushed
the
wasm/fastarray
branch
from
f18d92f
to
2982cfa
Compare
chakrabot
pushed a commit
that referenced
this pull request
Feb 17, 2017
Merge pull request #2423 from Cellule:wasm/fastarray Closes #1888 Related #2100 This PR implements the fast array (aka 8GB array) for WebAssembly on Windows x64. I have put the feature under a flag (turned on by default) to help with testing and possibly debugging future issues. This creates a new type of ArrayBuffer, `WebAssemblyArrayBuffer ` which, since the creation is controlled within WebAssembly, always allocate the buffer in virtual memory regardless of size or asm.js constraint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1888
Related #2100
This PR implements the fast array (aka 8GB array) for WebAssembly on Windows x64.
I have put the feature under a flag (turned on by default) to help with testing and possibly debugging future issues.
This creates a new type of ArrayBuffer,
WebAssemblyArrayBufferwhich, since the creation is controlled within WebAssembly, always allocate the buffer in virtual memory regardless of size or asm.js constraint.Performance data from the console version of the unity benchmark
This change is