Skip to content

Use search.followSymlinks for all searches #37000

Closed
@roblourens

Description

@roblourens
Member

search.followSymlinks is hooked up for searches using QueryBuilder (find in files, quickopen) but not searches initiated by extensions, or from workspaceContains. Maybe it should be.

Pro: A nice lever for people to have when they are having trouble with symlinks e.g. from cnpm/pnpm. Also, if the user has indicated that they have a setup where it doesn't make sense for their searches to follow symlinks, then the same should apply for other searches.

Con: User settings should not impact extensions in this case

cc @chrmarti I said I would file this last week

Activity

added this to the October 2017 milestone on Oct 26, 2017
self-assigned this
on Oct 26, 2017
chrmarti

chrmarti commented on Oct 26, 2017

@chrmarti
Collaborator

Sounds good to me. We can refine it later if there is any need.

chrmarti

chrmarti commented on Oct 30, 2017

@chrmarti
Collaborator

Thanks!

changed the title [-]Maybe use search.followSymlinks for all searches[/-] [+]Use search.followSymlinks for all searches[/+] on Oct 30, 2017
added a commit that references this issue on Oct 31, 2017

Fix #37000 - use search.followSymlinks for all searches

0f08e03
locked and limited conversation to collaborators on Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

searchSearch widget and operation issuesverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @roblourens@chrmarti

      Issue actions

        Use search.followSymlinks for all searches · Issue #37000 · microsoft/vscode