You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this ok:
make.top.equalTo(self.view.mas_safeAreaLayoutGuideTop);
make.left.equalTo(self.view.mas_safeAreaLayoutGuideLeft);
make.right.equalTo(self.view.mas_safeAreaLayoutGuideRight);
this crash:
make.top.left.right.equalTo(self.view.mas_safeAreaLayoutGuide);
Do not understand why this change, with the use of examples do not match, easy to read down
Provided examples of use
make.edges.equalTo (self.view.mas_safeAreaLayoutGuide) .inset (10.0);
make.right.bottom.equalTo (self.view.mas_safeAreaLayoutGuide);
make.width.height.equalTo (self.view.mas_safeAreaLayoutGuide) .sizeOffset (CGSizeMake (- 40.0, - 40.0));
When release new version?
I see the Demo define is OK
(MASViewAttribute *)mas_safeAreaLayoutGuide {
return [[MASViewAttribute alloc] initWithView:self item:self.safeAreaLayoutGuide layoutAttribute:NSLayoutAttributeNotAnAttribute];
}
but in release 1.1.0 version is
Activity
cntrump commentedon Oct 16, 2017
so sorry, safeAreaLayoutGuide is my PR.
by default, self.view.mas_safeAreaLayoutGuide is self.view.mas_safeAreaLayoutGuideBottom
CDYeah commentedon Oct 17, 2017
Do not understand why this change, with the use of examples do not match, easy to read down
Provided examples of use
make.edges.equalTo (self.view.mas_safeAreaLayoutGuide) .inset (10.0);
make.right.bottom.equalTo (self.view.mas_safeAreaLayoutGuide);
make.width.height.equalTo (self.view.mas_safeAreaLayoutGuide) .sizeOffset (CGSizeMake (- 40.0, - 40.0));
cntrump commentedon Oct 17, 2017
@CDYeah you are right, it is my mistake
iwill commentedon Oct 17, 2017
#473 fixed this issue.
ayang229 commentedon Nov 12, 2017
When release new version?
I see the Demo define is OK
return [[MASViewAttribute alloc] initWithView:self item:self.safeAreaLayoutGuide layoutAttribute:NSLayoutAttributeNotAnAttribute];
}
but in release 1.1.0 version is
return [[MASViewAttribute alloc] initWithView:self item:self.safeAreaLayoutGuide layoutAttribute:NSLayoutAttributeBottom];
}
iwill commentedon Nov 12, 2017
@robertjpayne We need release a new version for iOS 11 and iPhone X.
sclcoder commentedon Nov 20, 2017
is this just a mistake?
wuweili commentedon Nov 27, 2017
@iwill when did a new version for iOS 11 and iPhone X will release? Now 1.1.0 will crash
iwill commentedon Nov 27, 2017
@wuweili Sorry, I'm also waiting for it ...
iwill commentedon Nov 27, 2017
I'm using a gist temporarily which works fine.
LINAICAI commentedon Mar 22, 2018
I see the source code:
mas_safeAreaLayoutGuide is isEqual to mas_safeAreaLayoutGuideBottom
so if you use mas_safeAreaLayoutGuide to code:
make.edges.equalTo(self.view.mas_safeAreaLayoutGuide);
it mean :
make.edges.equalTo(self.view.mas_safeAreaLayoutGuideBottom);
so it crash
to resolve , you can use:
make.top.equalTo(self.view.mas_safeAreaLayoutGuideTop);
make.bottom.equalTo(self.view.mas_safeAreaLayoutGuideBottom);
make.left.equalTo(self.view.mas_safeAreaLayoutGuideLeft);
make.right.equalTo(self.view.mas_safeAreaLayoutGuideRight);
instead
yimao009 commentedon Jun 25, 2018
why demo is ok?
pingwinator commentedon Jul 19, 2018
@yimao009 because demo uses the latest version with this fix. The latest cocoapods version has this problem. Just compare
UIView+MASAdditions.m
file in your project and from github. https://github.com/SnapKit/Masonry/blob/master/Masonry/View%2BMASAdditions.m#L132pingwinator commentedon Jul 19, 2018
@cloudkite Could you bump version? or I could do it and prepare a pull request.
7 remaining items