[Foundation] slices of slices that use range expressions incorrectly calculated relative indexing #10584
+38
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test and merge |
…calculated relative indexing
phausler
force-pushed
the
slice_range_expressions
branch
from
b3afbaa to
9648228
Compare
|
@swift-ci please test and merge |
This was referenced Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RangeExpression variants of slicing incorrectly passed
0..<R.Bounds.maxwhich should be the slice region of the Data.This resolves the issues:
rdar://problem/32982494
rdar://problem/32983214 aka [SR-5292]: Another Data slice-related crash