Prevent null pointer 'Type' from being dereferenced #295
+380
−378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ->castTo<ArchetypeType>(); | ||
| auto typeVar = createTypeVariable(getConstraintLocator( | ||
| Type mappedType = ArchetypeBuilder::mapTypeIntoContext(dc, gp); | ||
| if (mappedType) { |
There was a problem hiding this comment.
What should happen if this check fails?
There was a problem hiding this comment.
It would mean the archetype builder was not set up properly.
You could try to see what the offending 'gp' actually is, and what generic signature it comes from vs what generic signature the archetype builder was configured with.
Usually getting to the root cause of something leads to better code and fixes more crashes.
There was a problem hiding this comment.
Makes sense, I will dive deeper.
AlexDenisov
force-pushed
the
archetype_null_pointer_dereference
branch
from
cd9adc2 to
85ab00d
Compare
|
Fixed by c258f99 |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Track armed events in muxnotes closely
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Add LineSDK to compatibility suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 323 crashes.
/cc @DougGregor