[Typo] Replace PR#514-525 with one large PR #561
Conversation
|
@gottesmm The code is verified passing |
|
@benlangmuir I just looked at the first commit. |
|
(i.e. the rest of the commits need to be looked at). |
|
Squashed into a single commit. |
|
@gottesmm I looked at the rest of the changes, which LGTM. My question was about a specific change that you requested (in #501):
Do we really want to drop the "FIXME" in this comment? |
|
That was not my intention. I just meant the text after the FIXME. |
| // FIXME: we work around canonicalization of PolymorphicFunctionType | ||
| // by generating GenericSignature and transforming the input, output | ||
| // We work around the canonicalization of PolymorphicFunctionType | ||
| // by generating a GenericSignature and transforming the input, output |
There was a problem hiding this comment.
@practicalswift could you add the FIXME back here (per @gottesmm's clarification), and then re-squash?
|
@benlangmuir Re-added FIXME as per @gottesmm's request and re-squashed. Please let me know if any further changes are needed :-) |
[Typo] Replace PR#514-525 with one large PR
[Stress tester XFails] Update XFails
As requested in #526.