I have been looking for something like this in collectd for a while. Glad to see some work is being done. I would like to see this get merged. I'll patch this locally and see how it works for my needs and post back here.

See my comment here #1107 (comment) on my findings. Turns out I needed both PRs not just this one.

@ymettier - this patch restores support for TypeInstance in ts_create()

diff --git a/src/target_set.c b/src/target_set.c
index 5e9d087..da2d307 100644
--- a/src/target_set.c
+++ b/src/target_set.c
@@ -177,6 +177,9 @@ static int ts_create (const oconfig_item_t *ci, void **user_data) /* {{{ */
       status = ts_config_add_string (&data->type, child,
           /* may be empty = */ 0);
 #endif
+    else if (strcasecmp ("TypeInstance", child->key) == 0)
+      status = ts_config_add_string (&data->type_instance, child,
+          /* may be empty = */ 1);
     else if (strcasecmp ("MetaDataSet", child->key) == 0)
       status = ts_config_add_meta (&data->meta, child,
           /* may be empty = */ 1);

ooops

Thanks @ciomaire . Fixed in commit a89fc92.
Also merged in PR #1107.

Regards,
Yves

This is a very nice feature, fairly crucial for deployments to many machines with various identifying characteristics (ie.g. datacenter, rack, cluster, etc.). Without additional metadata, slicing and dicing metrics gets messy and difficult.

👍 this feature will be very useful for us. This PR is 6 months old, is there any reason for not being merged?

@yogeswaran : no reason as far as I know.
@octo or @mfournier : what do you think ?

@ymettier This URL:#1107

Where is not
<Rule "opentsdb_load">
<Match "regex">
Plugin "^load$"

<Target "set">
MetaDataSet "tsdb_tag_pluginInstance" "load"
MetaDataSet "tsdb_prefix" "sys."


<Rule "opentsdb_swap">
<Match "regex">
Plugin "^swap$"

<Target "set">
MetaDataSet "tsdb_tag_pluginInstance" "swap"
MetaDataSet "tsdb_prefix" "sys."

I have a doubt：The following few write where？

tsdb_prefix Will prefix the OpenTSDB (also prefix tsdb_id if defined)
tsdb_id Replace the metric with this tag
tsdb_tag_plugin
tsdb_tag_pluginInstance
tsdb_tag_type
tsdb_tag_typeInstance
tsdb_tag_dsname When defined, tsdb_tag_* removes the related item from metric id.
If it is not empty, it will be the key of an opentsdb tag (the value is the item itself)
If it is empty, no tag is defined.