Skip to content

Tests to run always specified on command line, even if running all tests in executable #18

Closed
@DominikGrabiec

Description

@DominikGrabiec

The bug is that all of the tests suites are specified in the filter on the command line if the whole project is run or even run all is selected.

This occurs because there is a bug in the CommandLineGenerator.AllTestCasesOfExecutableAreRun function. It assumes that the AllTestCases variable only contains tests for that executable, but it actually contains all of the tests for all executables to be run.

To reproduce:

  • Make a solution with two test executable projects and add tests to both.
  • Put a breakpoint in one of the tests
  • In Test Explorer select the project view and right click on one project and "Debug Selected Tests" or even "Debug All".
  • When the breakpoint is hit, check Process Explorer for the test executable and examine the command line parameters.

If running all the tests in an executable there should be no command line parameters.

Activity

csoltenborn

csoltenborn commented on Jan 8, 2016

@csoltenborn
Owner

Thanks for your excellent bug report. However, I think the assumption in CommandLineGenerator should be fine - I decided to select the test cases for the according executable already in SequentialTestRunner, which should fix the issue, too, and additionally be more consistent with what shall actually happen.

self-assigned this
on Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @DominikGrabiec@csoltenborn

      Issue actions

        Tests to run always specified on command line, even if running all tests in executable · Issue #18 · csoltenborn/GoogleTestAdapter