-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fixed compile-time error #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Sonnet is only compatible with legacy, right?
<https://mailtrack.io/> Sent with Mailtrack
<https://mailtrack.io/install?source=signature&lang=en&referral=r.aguirre62@gmail.com&idSignature=22>
My highest regards,
Rolando P. Aguirre
@rpaguirre
…On Fri, Apr 7, 2017 at 11:38 PM, googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.
------------------------------
- If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data <https://cla.developers.google.com/clas> and verify
that your email is set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- If you signed the CLA as a corporation, please let us know the
company's name.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYfWQf_KeXK0_Hpqbxm2oB_DW3OvLgs8ks5rtytLgaJpZM4M3nU->
.
|
@google-admin: This project has already LICENSE file with Apache License 2.0 included, which I will respect. I have already signed agreement with Github, which I believe is binding for all projects posted here. Please see: https://help.github.com/articles/github-terms-of-service. Here is a relevant quote from it:
Is your CLA conflicting this agreement with Github or the Apache License 2.0 of this project that you are requesting to sign an additional Contributor License Agreements? In particular I wonder why I have to disclose my address and phone number to Google in order to make a contribution. |
Very simply, if you want us to take your patch, you need to comply with the CLA requirements. We can revisit the inherent CLA of the apache license in a different bug, but we are not able to be flexible on this. |
This fix it for me too. |
@malcolmreynolds: Please fix the code. I will close this pull request once it is not needed. No credit is required. |
@esc @roman3017 We have pushed a different fix which does not remove the const semantics - please let me know if this fixes the issue. |
Assuming that I managed to clean the bazel caches correctly ( |
@malcolmreynolds: your fix 9d20983 works for me |
Fixes #5 issue