Fix the request cache keys to not hold references to the SearchContext. #21284
+169
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the request cache adds a `CacheEntity` object. It looks quite innocent but in practice it has a reference to a lambda that knows how to create a value. The issue is that this lambda has implicit references to the SearchContext object, which can be quite heavy since it holds a structured representation of aggregations for instance. This pull request splits the `CacheEntity` object from the object that generates cache values.
s1monw
suggested changes
Nov 2, 2016
| try { | ||
| context.queryResult().writeToNoId(out); | ||
| } catch (IOException e) { | ||
| throw new IllegalStateException("Could not serialize response", e); |
There was a problem hiding this comment.
maybe make this even an AssertionError?
| IndexShardCacheEntity cacheEntity = new IndexShardCacheEntity(shard, loader); | ||
| return indicesRequestCache.getOrCompute(cacheEntity, reader, cacheKey); | ||
| IndexShardCacheEntity cacheEntity = new IndexShardCacheEntity(shard); | ||
| boolean[] loadedFromCache = new boolean[] { true }; |
There was a problem hiding this comment.
do we need to return this, I think we can rely on that the loader is called when we load the result again so the caller can use this to obtain that boolean...?
| queryPhase.execute(context); | ||
| context.queryResult().writeToNoId(out); | ||
| try { |
There was a problem hiding this comment.
Can we just use a boolean here that we set to false when this loader is executed?
jpountz
added a commit
that referenced
this pull request
Nov 3, 2016
…t. (#21284) Currently the request cache adds a `CacheEntity` object. It looks quite innocent but in practice it has a reference to a lambda that knows how to create a value. The issue is that this lambda has implicit references to the SearchContext object, which can be quite heavy since it holds a structured representation of aggregations for instance. This pull request splits the `CacheEntity` object from the object that generates cache values.
jpountz
added a commit
that referenced
this pull request
Nov 3, 2016
…t. (#21284) Currently the request cache adds a `CacheEntity` object. It looks quite innocent but in practice it has a reference to a lambda that knows how to create a value. The issue is that this lambda has implicit references to the SearchContext object, which can be quite heavy since it holds a structured representation of aggregations for instance. This pull request splits the `CacheEntity` object from the object that generates cache values.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the request cache adds a
CacheEntityobject. It looks quite innocentbut in practice it has a reference to a lambda that knows how to create a value.
The issue is that this lambda has implicit references to the SearchContext
object, which can be quite heavy since it holds a structured representation of
aggregations for instance.
This pull request splits the
CacheEntityobject from the object that generatescache values.