-
-
Notifications
You must be signed in to change notification settings - Fork 892
IE8 defineProperty/getOwnPropertyDescriptor clash with shim #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hax
added a commit
to hax/es5-shim
that referenced
this issue
Jul 18, 2011
I think I'm having problems because of this. IE8 gives me this error: |
Doesn't look like it was merged, sadly. |
This needs a retry if anyone is up for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As currently implemented, the Object.defineProperty shim will not install on IE8 because IE8 already has such a method. However, the built-in IE8 method only works when applied to DOM objects.
Because the shim does not get installed, the emulation of value: property descriptors on arbitrary objects is not available although it could be. (get: and set: descriptors are a lost cause). The shim installation needs better detection of IE8 (see http://blogs.msdn.com/b/ie/archive/2010/09/07/transitioning-existing-code-to-the-es5-getter-setter-apis.aspx) and should probably and the installed shim should first call the built-in method and then only call the the emulation if the built-in throws).
IE8 also has a DOM only getOwnPropertyDescriptor so the same issues apply to it.
The text was updated successfully, but these errors were encountered: