Auto-detect more common editors #2636

gaearon · 2017-06-27T15:18:25Z

Let's send PRs for autodetecting more common editors for the error overlay!
The feature already works both on macOS and Windows (thanks @levrik).

Currently detected editors are here:

const COMMON_EDITORS_OSX = {
  '/Applications/Atom.app/Contents/MacOS/Atom': 'atom',
  '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta': '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta',
  '/Applications/Sublime Text.app/Contents/MacOS/Sublime Text': '/Applications/Sublime Text.app/Contents/SharedSupport/bin/subl',
  '/Applications/Sublime Text 2.app/Contents/MacOS/Sublime Text 2': '/Applications/Sublime Text 2.app/Contents/SharedSupport/bin/subl',
  '/Applications/Visual Studio Code.app/Contents/MacOS/Electron': 'code',
};

const COMMON_EDITORS_WIN = [
  'Code.exe',
  'atom.exe',
  'sublime_text.exe',
  'notepad++.exe',
];

If your favorite editor isn't in the list, but supports running from the command line with a line number, send a PR to launchEditor.js adding it to the list, and specifying its argument format.

To verify your change works, edit node_modules/react-dev-utils/launchEditor.js in your project, add a throw new Error('hi') to a component, and then verify that clicking on the error overlay takes you to the right place.

The text was updated successfully, but these errors were encountered:

jantimon · 2017-06-27T15:24:09Z

This feature is really cool - you should create an independent npm package out of that! 👍

gaearon · 2017-06-27T15:24:50Z

Agree, we should extract it at some point! It's originally forked from React Native but we added more features and might eventually make RN depend on it.

ntucker · 2017-06-27T16:27:37Z

why no linux? :(

gaearon · 2017-06-27T20:46:08Z

@ntucker Because nobody contributed Linux support yet. Would you like to do that?

miraage · 2017-06-28T06:39:42Z

In my opninion, WebStorm,PhpStorm and Idea should also be there. Despite the fact that JetBrains IDEs are offering to create a shortcut, still not a lot of people do it.

gaearon · 2017-06-28T10:49:51Z

Happy to take PRs!

bunshar · 2017-06-28T12:07:04Z

@gaearon I would like to contributed Linux support. Should I create another ticket?

gaearon · 2017-06-28T12:12:00Z

@bunshar This ticket is fine—just send a PR!

reznord · 2017-07-03T06:26:40Z

@gaearon in OSX you can launch Atom Beta using atom-beta command.

So,

  '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta': '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta',

can be

  '/Applications/Atom Beta.app/Contents/MacOS/Atom Beta': 'atom-beta',

gaearon · 2017-07-03T14:59:55Z

Happy to take PRs (although if it works fine, I wouldn't change it).

reznord · 2017-07-03T15:06:28Z

Can I take this up and add Linux support as well?

Sent from my OnePlus ONEPLUS A3003 using FastHub

gaearon · 2017-07-03T15:07:49Z

Sure.

reznord · 2017-07-07T05:25:02Z

@gaearon for opening CRA project in Visual Studio Code, we cannot use code as mentioned here unless we go and install the command line tools from the command pallet in VS Code.

Please find the documentation for setting up VS Code here

Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. Removed older integrations of AppCode, IntelliJ IDEA https://www.jetbrains.com/help/idea/opening-files-from-command-line.html https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12 Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM Relates to facebook#2636

Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. Removed older integrations of AppCode, IntelliJ IDEA https://www.jetbrains.com/help/idea/opening-files-from-command-line.html https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12 Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM Relates to #2636

Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. Removed older integrations of AppCode, IntelliJ IDEA https://www.jetbrains.com/help/idea/opening-files-from-command-line.html https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12 Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM Relates to facebook#2636

Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. Removed older integrations of AppCode, IntelliJ IDEA https://www.jetbrains.com/help/idea/opening-files-from-command-line.html https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12 Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM Relates to #2636

Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. Removed older integrations of AppCode, IntelliJ IDEA https://www.jetbrains.com/help/idea/opening-files-from-command-line.html https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12 Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM Relates to facebook#2636

Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. Removed older integrations of AppCode, IntelliJ IDEA https://www.jetbrains.com/help/idea/opening-files-from-command-line.html https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12 Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM Relates to #2636

* Auto-detect running editor on Linux for error overlay Basic support of auto detecting running editor for #2636. Tested on Ubuntu 16.04. It detects few editors. JetBrains products should start by wrapper like /usr/local/bin/webstorm. Otherwise it takes a lot of time to open editor. * Comments fixed. * List all processes owned by you * Comment rewording

* Auto-detect running editor on Linux for error overlay Basic support of auto detecting running editor for facebook#2636. Tested on Ubuntu 16.04. It detects few editors. JetBrains products should start by wrapper like /usr/local/bin/webstorm. Otherwise it takes a lot of time to open editor. * Comments fixed. * List all processes owned by you * Comment rewording

Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. Removed older integrations of AppCode, IntelliJ IDEA https://www.jetbrains.com/help/idea/opening-files-from-command-line.html https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12 Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM Relates to facebook#2636

* Auto-detect running editor on Linux for error overlay Basic support of auto detecting running editor for facebook#2636. Tested on Ubuntu 16.04. It detects few editors. JetBrains products should start by wrapper like /usr/local/bin/webstorm. Otherwise it takes a lot of time to open editor. * Comments fixed. * List all processes owned by you * Comment rewording

Autodetect PyCharm (Pro and CE), WebStorm, PhpStorm, IntelliJ IDEA, RubyMine, CLion, and AppCode Added IntelliJ IDEA, RubyMine, CLion, and AppCode to list of IDEs. It has the same signature as WebStorm and PhpStorm `<editor> <projectPath> --line <number> <filePath>` so it can reuse the logic from those. Removed older integrations of AppCode, IntelliJ IDEA https://www.jetbrains.com/help/idea/opening-files-from-command-line.html https://www.jetbrains.com/help/pycharm/opening-files-from-command-line.html https://www.jetbrains.com/help/phpstorm/opening-files-from-command-line.html https://www.jetbrains.com/help/ruby/opening-files-from-command-line.html https://www.jetbrains.com/help/webstorm/opening-files-from-command-line.html Tested with Appcode 2017.1.3, CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on MacOS 10.12 Tested with 64-bit CLion 2017.1.3, Intellij Idea 2017.1.5, PhpStorm 2017.1.4, PyCharm (Pro and CE) 2017.1.4, RubyMine 2017.1.5, and WebStorm 2017.1.4 on a Windows 10 VM Relates to #2636

Adds support for the error overlay to detect and open the file with the error in MacVim. Relates to #2636.

Grsmto · 2018-02-06T14:30:31Z

@reznord thanks, I just spent an hour debugging this and figured out it wasn't working because I didn't have the vscode CLI tool installed. :)
@gaearon are you open to PR to improve the error message? It would be cool if it was telling to VSCode users to install the CLI first if the code command is not found.

Adds support for the error overlay to detect and open the file with the error in MacVim. Relates to facebook#2636.

Clicking Error overlay should feed the correct line number for gvim. Added `gvim` in `COMMON_EDITORS_LINUX`, launches new gvim when it is running. Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM Relates to facebook#2636.

Clicking Error overlay should feed the correct line number for gvim. Added `gvim` in `COMMON_EDITORS_LINUX`, launches new gvim when it is running. Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM Relates to #2636.

stale · 2018-11-02T06:26:13Z

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs.

gaearon added contributions: up for grabs! difficulty: starter labels Jun 27, 2017

gaearon mentioned this issue Jun 27, 2017

Click to Open Editor Feature of Error Overlay Documentation #2406

Closed

danrr mentioned this issue Jul 9, 2017

Autodetect JetBrains IDEs #2754

Merged

gulderov mentioned this issue Sep 6, 2017

Auto-detect running editor on Linux for error overlay #3077

Merged

gnapse mentioned this issue Dec 4, 2017

Autodetect MacVim editor #3545

Merged

gaearon pushed a commit that referenced this issue Jan 8, 2018

Autodetect MacVim editor (#3545)

1b067c5

Adds support for the error overlay to detect and open the file with the error in MacVim. Relates to #2636.

ifedyukin mentioned this issue Feb 5, 2018

Autodetect GoLand editor #3980

Merged

hackhat mentioned this issue May 26, 2018

Pre-compiled source code ( pre-minified ) can be seen on Chrome Sources kriasoft/react-starter-kit#1600

Closed

Pavek pushed a commit to Pavek/create-react-app that referenced this issue Jul 10, 2018

Autodetect MacVim editor (facebook#3545)

6a83f43

Adds support for the error overlay to detect and open the file with the error in MacVim. Relates to facebook#2636.

identor mentioned this issue Oct 1, 2018

Feed correct line number to gvim on launch #5202

Merged

stale bot added the stale label Nov 2, 2018

Timer closed this as completed Nov 2, 2018

lock bot locked and limited conversation to collaborators Jan 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-detect more common editors #2636

Auto-detect more common editors #2636

gaearon commented Jun 27, 2017 •

edited

jantimon commented Jun 27, 2017

gaearon commented Jun 27, 2017

ntucker commented Jun 27, 2017

gaearon commented Jun 27, 2017

miraage commented Jun 28, 2017

gaearon commented Jun 28, 2017

bunshar commented Jun 28, 2017

gaearon commented Jun 28, 2017

reznord commented Jul 3, 2017

gaearon commented Jul 3, 2017

reznord commented Jul 3, 2017

gaearon commented Jul 3, 2017

reznord commented Jul 7, 2017 •

edited

Grsmto commented Feb 6, 2018

stale bot commented Nov 2, 2018

Auto-detect more common editors #2636

Auto-detect more common editors #2636

Comments

gaearon commented Jun 27, 2017 • edited

jantimon commented Jun 27, 2017

gaearon commented Jun 27, 2017

ntucker commented Jun 27, 2017

gaearon commented Jun 27, 2017

miraage commented Jun 28, 2017

gaearon commented Jun 28, 2017

bunshar commented Jun 28, 2017

gaearon commented Jun 28, 2017

reznord commented Jul 3, 2017

gaearon commented Jul 3, 2017

reznord commented Jul 3, 2017

gaearon commented Jul 3, 2017

reznord commented Jul 7, 2017 • edited

Grsmto commented Feb 6, 2018

stale bot commented Nov 2, 2018

gaearon commented Jun 27, 2017 •

edited

reznord commented Jul 7, 2017 •

edited