Skip to content

CFURLCreateStringByReplacingPercentEscapesUsingEncoding() deprecated in iOS 9.0 #359

Closed
@funnel20

Description

@funnel20
Contributor

In IASKAppSettingsWebViewController.h, CFURLCreateStringByReplacingPercentEscapesUsingEncoding() is used, which is deprecated in iOS 9.0.
Xcode suggest to use CFURLCreateStringByReplacingPercentEscapes() "which always uses the recommended UTF-8 encoding."

The code will then be (last input argument 'kCFStringEncodingUTF8' is removed):

value =  CFBridgingRelease(CFURLCreateStringByReplacingPercentEscapes(kCFAllocatorDefault,
                                                                                      (CFStringRef)value,
                                                                                      CFSTR("")));

CFURLCreateStringByReplacingPercentEscapes() is supported since iOS 2.0, so it can be used safely.

Activity

PGSeattle

PGSeattle commented on Mar 5, 2017

@PGSeattle

+1 for funnel20's suggestion.
value = CFBridgingRelease(CFURLCreateStringByReplacingPercentEscapes(kCFAllocatorDefault,
(CFStringRef)value,
CFSTR("")));

added a commit that references this issue on Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @futuretap@PGSeattle@funnel20

        Issue actions

          CFURLCreateStringByReplacingPercentEscapesUsingEncoding() deprecated in iOS 9.0 · Issue #359 · futuretap/InAppSettingsKit