Remove the gflags dependency. #97
Merged
+51
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems easier to parse the flags manually (no getopt, because Visual Studio environment is not POSIX) than to find a way to use gflags on all the platforms people compile Guetzli on.
jyrkialakuijala
approved these changes
Mar 20, 2017
This was referenced Mar 20, 2017
Closed
5 tasks
robryk
added a commit
to robryk/guetzli
that referenced
this pull request
Mar 21, 2017
This was forgotten back in google#97.
jyrkialakuijala
pushed a commit
that referenced
this pull request
Mar 21, 2017
This was forgotten back in #97.
bradbaris
added a commit
to bradbaris/guetzli-bin
that referenced
this pull request
May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems easier to parse the flags manually (no getopt, because Visual
Studio environment is not POSIX) than to find a way to use gflags on all
the platforms people compile Guetzli on.