-
Notifications
You must be signed in to change notification settings - Fork 15.7k
fix compile error on centos in metadata.h for constructors. #2599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and I have already tested the compile process on centos. CLA fixed.
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
Can one of the admins verify this patch? |
LGTM |
Has this made it into 3.2.1? I just tried that one after trying 3.2.0 and I'm still seeing this issue. EDIT: Just tried the 3.3.x branch which has this included and I'm still getting an error about InternalMetadataWithArenaBase. EDIT2: ./google/protobuf/metadata_lite.h: In constructor ‘google::protobuf::internal::InternalMetadataWithArenaLite::InternalMetadataWithArenaLite(google::protobuf::Arena*)’:
./google/protobuf/metadata_lite.h:170: error: class ‘google::protobuf::internal::InternalMetadataWithArenaLite’ does not have any field named ‘InternalMetadataWithArenaBase’
make[2]: *** [google/protobuf/any.pb.lo] Error 1
make[2]: Leaving directory `/root/protobuf-3.3.x/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/root/protobuf-3.3.x'
make: *** [all] Error 2 This is for: Red Hat Enterprise Linux Server release 6.8 (Santiago) |
+1. I'm having the same issue with RHEL r6.8 (Satniago) and Protobuf 3.3. @deejross do you have a workaround? Note that the fix was to metadata.h but the issue I'm having is with metadata_lite.h:170 which is included from metadata.h:41 |
@deejross, I have a workaround. In metadata_lite.h:169: replace: with: |
I use the @jjpepper method and I hacve success, but I don't understand why this problem show on CentOS6.x? |
this fix seems to work for RHEL 6 and protobuf 3.3.x. what about RHEL 6 with 3.2.x? i am unable to compile there with the change above. there is no metadata_lite.h (only a metadata.h) which i tried to apply the same change with no luck. can anyone help? |
I have already tested the compile process on centos. CLA fixed.