Unable to build after upgrading to Cordova 7.0.0 #99

cindyliu-yb · 2017-05-05T10:31:09Z

Hello,

I can't do cordova build because of something in the plugin after upgrading to Cordova 7.0.0. See the error below. Once I remove the plugin, I can build successfully.

Could you fix this? Thanks in advance!

ihadeed · 2017-05-06T01:43:49Z

@cindyliu-yb ~~I don't think this is related to this plugin. I was just experiencing the same issue. Run the following command to fix it:~~

sudo npm i -g cordova@6.5.0

peterpeterparker · 2017-05-06T12:01:38Z

@ihadeed it's related to this plugin I think...

ionic plugin add ionic-plugin-deeplink
ionic platform rm ios
ionic platform add ios

=> Error: Cannot find module '../plugman/platforms/ios'

ionic plugin rm ionic-plugin-deeplink
ionic platform rm ios
ionic platform add ios
ionic plugin add ionic-plugin-deeplink

=> ok but fail later on ionic build ios --prod

ionic plugin rm ionic-plugin-deeplink
ionic platform rm ios
ionic platform add ios
ionic build ios --prod

=> ok

P.S.: I didn't faced that error with the android platform, was alright

peterpeterparker · 2017-05-06T12:27:20Z

In xcodePreferences.js:

try {
// try pre-5.0 cordova structure
platform_ios = context.requireCordovaModule('cordova-lib/src/plugman/platforms')['ios'];
projectFile = platform_ios.parseProjectFile(iosPlatformPath());
} catch (e) {
  // let's try cordova 5.0 structure
  platform_ios = context.requireCordovaModule('cordova-lib/src/plugman/platforms/ios');
  projectFile = platform_ios.parseProjectFile(iosPlatformPath());
}

But 'cordova-lib/src/plugman/platforms/ios' seems to doesn't exist anymore in Cordova 7.0.0, see following commit:

apache/cordova-lib@64fea70

janpio · 2017-05-06T13:03:32Z

So this https://github.com/driftyco/ionic-plugin-deeplinks/blob/master/hooks/afterPrepareHook.js
is including this https://github.com/driftyco/ionic-plugin-deeplinks/blob/master/hooks/lib/ios/xcodePreferences.js where these lines don't do what they are supposed to do any more: https://github.com/driftyco/ionic-plugin-deeplinks/blob/master/hooks/lib/ios/xcodePreferences.js#L151-L159

The commit @peterpeterparker linked to seems to have removed some deprecated stuff. Was there a deprecation notice output when executing this with Cordova 6.5.0?

peterpeterparker · 2017-05-06T13:25:49Z

He you go, a quick and dirty solution. In xcodePreferences.js, replace method loadProjectFile with following code:

function loadProjectFile() {
  var platform_ios;
  var projectFile;

  try {
    // try pre-5.0 cordova structure
    platform_ios = context.requireCordovaModule('cordova-lib/src/plugman/platforms')['ios'];
    projectFile = platform_ios.parseProjectFile(iosPlatformPath());
  } catch (e) {
      try {
          // let's try cordova 5.0 structure
          platform_ios = context.requireCordovaModule('cordova-lib/src/plugman/platforms/ios');
          projectFile = platform_ios.parseProjectFile(iosPlatformPath());
      } catch (e) {
          // Then cordova 7.0
          var project_files = context.requireCordovaModule('glob').sync(path.join(iosPlatformPath(), '*.xcodeproj', 'project.pbxproj'));

          if (project_files.length === 0) {
            throw new Error('does not appear to be an xcode project (no xcode project file)');
          }

          var pbxPath = project_files[0];

          var xcodeproj = context.requireCordovaModule('xcode').project(pbxPath);
          xcodeproj.parseSync();

          projectFile = {
              'xcode': xcodeproj,
              write: function () {
                  var fs = context.requireCordovaModule('fs');

              var frameworks_file = path.join(iosPlatformPath(), 'frameworks.json');
              var frameworks = {};
              try {
                  frameworks = context.requireCordovaModule(frameworks_file);
              } catch (e) { }

              fs.writeFileSync(pbxPath, xcodeproj.writeSync());
                  if (Object.keys(frameworks).length === 0){
                      // If there is no framework references remain in the project, just remove this file
                      context.requireCordovaModule('shelljs').rm('-rf', frameworks_file);
                      return;
                  }
                  fs.writeFileSync(frameworks_file, JSON.stringify(this.frameworks, null, 4));
              }
          };
      }
  }

  return projectFile;
}

ihadeed · 2017-05-08T07:55:18Z

@peterpeterparker thanks for the fix. You should submit a PR :)

peterpeterparker · 2017-05-08T18:17:08Z

@ihadeed sure, would be my pleasure: #103

#99: Fix Xcode project file detection for Cordova 7

aramando · 2017-05-17T15:23:53Z

I've come up with a much simpler solution. Can anyone confirm this works as intended? It appears to work OK for me, but I'm insufficiently familiar with the inner machinations of Cordova to know how good a solution it is.

function loadProjectFile() {
  var platform_ios;
  var projectFile;
  try {
    // try pre-5.0 cordova structure
    platform_ios = context.requireCordovaModule('cordova-lib/src/plugman/platforms')['ios'];
    projectFile = platform_ios.parseProjectFile(iosPlatformPath());
  } catch (e) {
    try {
      // let's try cordova 5.0 structure
      platform_ios = context.requireCordovaModule('cordova-lib/src/plugman/platforms/ios');
      projectFile = platform_ios.parse(iosPlatformPath());
    } catch (e) {
      // try cordova 7.0 structure
      var iosPlatformApi = require(path.join(iosPlatformPath(), '/cordova/Api'));
      var projectFileApi = require(path.join(iosPlatformPath(), '/cordova/lib/projectFile.js'));
      var locations = (new iosPlatformApi()).locations;
      projectFile = projectFileApi.parse(locations);
    }
  }
  return projectFile;
}

ihadeed · 2017-05-17T18:21:13Z

@peterpeterparker 's PR was merged, this should be fixed now.

peterpeterparker · 2017-05-17T19:27:31Z

@ihadeed yes it's merged and confirm it's fixed but of course Im not against a easier cuter solution, like I said, I did a quick fix

mlynch · 2017-09-19T17:25:22Z

btw I removed all the hooks. Caused more problems than they were worth. See #82

Copied from ionic-team/ionic-plugin-deeplinks#99

Prodev2017 · 2017-12-16T02:42:14Z

I tried to add ionic-plugin-deeplink
but i got errors

An error occurred while running cordova plugin add ionic-plugin-deeplink --save (exit

    code 1):
    
    Error: Registry returned 404 for GET on 
    https://registry.npmjs.org/ionic-plugin-deeplink

Please help me

timothylombrana · 2018-01-13T22:08:42Z

Any update on installation error, I as well am getting a 404. Could really use the help.

peterpeterparker mentioned this issue May 6, 2017

[Cordova 7.0.0] Cannot find module '../plugman/platforms/ios' #100

Closed

abdohossam5 mentioned this issue May 7, 2017

cordova 7.0.0 can't find module '../plugman/platforms/ios' nordnet/cordova-hot-code-push#295

Closed

MarsupiL mentioned this issue May 8, 2017

Error: Cannot find module '../plugman/platforms/ios'. Deprecated code in xcodePreferences.js after upgrading to Cordova 7.0.0 nordnet/cordova-universal-links-plugin#110

Closed

mlynch added a commit that referenced this issue May 9, 2017

Merge pull request #103 from peterpeterparker/fix-cordova7

47d7020

#99: Fix Xcode project file detection for Cordova 7

ben-8409 mentioned this issue May 23, 2017

Incompatibility with Cordova 7.0 due to plugman being removed in cordova nordnet/cordova-universal-links-plugin#116

Closed

mikegleasonjr mentioned this issue Jul 26, 2017

Cordova-ios 4.4.0 Problems phonegap/phonegap-plugin-push#1701

Closed

mlynch closed this as completed Sep 19, 2017

flipflopapp added a commit to flipflopapp/cordova-universal-links-plugin that referenced this issue Oct 7, 2017

fix for issue related to cordova 7.0

be60a9b

Copied from ionic-team/ionic-plugin-deeplinks#99

pmwisdom mentioned this issue Jan 29, 2018

Meteor 1.6 build fails pmwisdom/meteor-background-geolocation-services#12

Open

Manduro pushed a commit to Manduro/ionic-plugin-deeplinks that referenced this issue May 22, 2018

ionic-team#99: Fix Xcode project file detection for Cordova 7

c161155

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to build after upgrading to Cordova 7.0.0 #99

Unable to build after upgrading to Cordova 7.0.0 #99

cindyliu-yb commented May 5, 2017

ihadeed commented May 6, 2017 •

edited

peterpeterparker commented May 6, 2017 •

edited

peterpeterparker commented May 6, 2017 •

edited

janpio commented May 6, 2017 •

edited

peterpeterparker commented May 6, 2017 •

edited

ihadeed commented May 8, 2017

peterpeterparker commented May 8, 2017

aramando commented May 17, 2017

ihadeed commented May 17, 2017

peterpeterparker commented May 17, 2017

mlynch commented Sep 19, 2017

Prodev2017 commented Dec 16, 2017

timothylombrana commented Jan 13, 2018

Unable to build after upgrading to Cordova 7.0.0 #99

Unable to build after upgrading to Cordova 7.0.0 #99

Comments

cindyliu-yb commented May 5, 2017

ihadeed commented May 6, 2017 • edited

peterpeterparker commented May 6, 2017 • edited

peterpeterparker commented May 6, 2017 • edited

janpio commented May 6, 2017 • edited

peterpeterparker commented May 6, 2017 • edited

ihadeed commented May 8, 2017

peterpeterparker commented May 8, 2017

aramando commented May 17, 2017

ihadeed commented May 17, 2017

peterpeterparker commented May 17, 2017

mlynch commented Sep 19, 2017

Prodev2017 commented Dec 16, 2017

timothylombrana commented Jan 13, 2018

ihadeed commented May 6, 2017 •

edited

peterpeterparker commented May 6, 2017 •

edited

peterpeterparker commented May 6, 2017 •

edited

janpio commented May 6, 2017 •

edited

peterpeterparker commented May 6, 2017 •

edited