Skip to content

[optimizeCb] Combine null and 3 as multi-case for argCount switch statement #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2016

Conversation

kingdido999
Copy link
Contributor

Instead of checking null value of argCount within switch expression, I combined null and 3 as a multi-case statement, which makes optimizeCb function more readable.

@coveralls
Copy link

coveralls commented Oct 17, 2016

Coverage Status

Coverage decreased (-0.2%) to 96.723% when pulling 5fe7576 on kingdido999:optimizeCb-switch into 0875760 on jashkenas:master.

@akre54
Copy link
Collaborator

akre54 commented Oct 26, 2016

Yeah I like this a lot better. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants