You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You don't need to put the compiled version into git like you did already (add build file in .gitignore).
Just add { “republish”: ‘make’ } to scripts field in ‘package.json’ and change the main filed to ./build/framer.js. And then I also recommend that moving most of the dependencies that used for build and test into ‘devDependencies’. That makes more npm friendly and save a lot of for npm install.
Hi there, any update about this? @jacobbubu's proposal seems quite straightforward to implement (with the required change that the republish task should be "make release" instead of just "make", I think). I could provide a PR myself —unless now there is any reason against doing this @koenbok? (I guess not as this issue is still open)
PS: actually, the main field in package.json points to lib/Framer.js which doesn't exist, even after building? That doesn't make sense anyway, right?, or am I missing something?
Hey @jperals, Framer doesn’t have semantic versioning, which makes it not so nice to work with in combination with npm. It’s (therefore?) not a popular use case either, making this issue very low priority. The main field is indeed outdated.
Activity
koenbok commentedon May 17, 2014
Sure. I don't see why not :-)
koenbok commentedon May 17, 2014
Here you go:
https://www.npmjs.org/package/framerjs
paulyoung commentedon May 17, 2014
👍
paulyoung commentedon May 18, 2014
When I
require('framerjs')
I getError: Cannot find module 'framerjs'
.paulyoung commentedon May 18, 2014
So, this is due to the build directory not being submitted as part of the package.
@koenbok - could you make that happen?
paulyoung commentedon May 18, 2014
Actually, Bower might be better for this. At least having a
component.json
file would let me try that out.paulyoung commentedon Jun 10, 2014
@koenbok - wondering if you'd mind following up here.
Add component.json
zanona commentedon Aug 5, 2015
As of v3.0.0 the
build/frame.js
file is not included making it impossible to depend on the framejs via npm? Perhaps this issue should be re-opened?jchavarri commentedon Nov 2, 2015
@zanona @paulyoung You can build automatically after installing, using the
scripts
key on your package.json:"scripts": { "postinstall": "cd ./node_modules/framerjs && make" }
jacobbubu commentedon Dec 15, 2015
I think this issue should be reopen due to the lack of compiled version of framerjs,
koenbok commentedon Dec 15, 2015
I keep them here: http://builds.framerjs.com/
But I don't like keeping them in git because you get huge nonsensical diffs.
jacobbubu commentedon Dec 15, 2015
You don't need to put the compiled version into git like you did already (add build file in .gitignore).
Just add
{ “republish”: ‘make’ }
toscripts
field in ‘package.json’ and change themain
filed to./build/framer.js
. And then I also recommend that moving most of the dependencies that used for build and test into ‘devDependencies’. That makes more npm friendly and save a lot of fornpm install
.koenbok commentedon Dec 15, 2015
Ok let's do it.
paulyoung commentedon Dec 15, 2015
For my own projects, I've followed similar steps to those outlined here: http://mammal.io/articles/using-es6-today/#publishing-to-npm
jperals commentedon Aug 14, 2017
Hi there, any update about this? @jacobbubu's proposal seems quite straightforward to implement (with the required change that the
republish
task should be"make release"
instead of just"make"
, I think). I could provide a PR myself —unless now there is any reason against doing this @koenbok? (I guess not as this issue is still open)PS: actually, the
main
field inpackage.json
points tolib/Framer.js
which doesn't exist, even after building? That doesn't make sense anyway, right?, or am I missing something?eelco commentedon Aug 17, 2017
Hey @jperals, Framer doesn’t have semantic versioning, which makes it not so nice to work with in combination with npm. It’s (therefore?) not a popular use case either, making this issue very low priority. The
main
field is indeed outdated.