Skip to content

Publish to npm? #71

@paulyoung

Description

@paulyoung

I'd like to create something that depends on Framer.

Activity

koenbok

koenbok commented on May 17, 2014

@koenbok
Owner

Sure. I don't see why not :-)

koenbok

koenbok commented on May 17, 2014

@koenbok
Owner
paulyoung

paulyoung commented on May 17, 2014

@paulyoung
Author

👍

paulyoung

paulyoung commented on May 18, 2014

@paulyoung
Author

When I require('framerjs') I get Error: Cannot find module 'framerjs'.

paulyoung

paulyoung commented on May 18, 2014

@paulyoung
Author

So, this is due to the build directory not being submitted as part of the package.

@koenbok - could you make that happen?

paulyoung

paulyoung commented on May 18, 2014

@paulyoung
Author

Actually, Bower might be better for this. At least having a component.json file would let me try that out.

paulyoung

paulyoung commented on Jun 10, 2014

@paulyoung
Author

@koenbok - wondering if you'd mind following up here.

added a commit that references this issue on Jun 11, 2014
zanona

zanona commented on Aug 5, 2015

@zanona

As of v3.0.0 the build/frame.js file is not included making it impossible to depend on the framejs via npm? Perhaps this issue should be re-opened?

jchavarri

jchavarri commented on Nov 2, 2015

@jchavarri
Contributor

@zanona @paulyoung You can build automatically after installing, using the scripts key on your package.json:

"scripts": { "postinstall": "cd ./node_modules/framerjs && make" }

jacobbubu

jacobbubu commented on Dec 15, 2015

@jacobbubu

I think this issue should be reopen due to the lack of compiled version of framerjs,

koenbok

koenbok commented on Dec 15, 2015

@koenbok
Owner

I keep them here: http://builds.framerjs.com/

But I don't like keeping them in git because you get huge nonsensical diffs.

jacobbubu

jacobbubu commented on Dec 15, 2015

@jacobbubu

You don't need to put the compiled version into git like you did already (add build file in .gitignore).
Just add { “republish”: ‘make’ } to scripts field in ‘package.json’ and change the main filed to ./build/framer.js. And then I also recommend that moving most of the dependencies that used for build and test into ‘devDependencies’. That makes more npm friendly and save a lot of for npm install.

koenbok

koenbok commented on Dec 15, 2015

@koenbok
Owner

Ok let's do it.

paulyoung

paulyoung commented on Dec 15, 2015

@paulyoung
Author

For my own projects, I've followed similar steps to those outlined here: http://mammal.io/articles/using-es6-today/#publishing-to-npm

jperals

jperals commented on Aug 14, 2017

@jperals

Hi there, any update about this? @jacobbubu's proposal seems quite straightforward to implement (with the required change that the republish task should be "make release" instead of just "make", I think). I could provide a PR myself —unless now there is any reason against doing this @koenbok? (I guess not as this issue is still open)

PS: actually, the main field in package.json points to lib/Framer.js which doesn't exist, even after building? That doesn't make sense anyway, right?, or am I missing something?

eelco

eelco commented on Aug 17, 2017

@eelco
Collaborator

Hey @jperals, Framer doesn’t have semantic versioning, which makes it not so nice to work with in combination with npm. It’s (therefore?) not a popular use case either, making this issue very low priority. The main field is indeed outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @eelco@zanona@paulyoung@koenbok@jchavarri

        Issue actions

          Publish to npm? · Issue #71 · koenbok/Framer