Optimization

kozmi55 · kozmi55 · commit 1a6f0ef46d3e · 2017-07-28T10:55:19.000+02:00
diff --git a/app/src/main/java/com/example/tamaskozmer/kotlinrxexample/model/UserRepository.kt b/app/src/main/java/com/example/tamaskozmer/kotlinrxexample/model/UserRepository.kt
@@ -32,15 +32,19 @@ class UserRepository(
     }
 
     private fun mapAnswersToAnswerViewModels(answers: List<Answer>): Single<List<AnswerViewModel>> {
-        val ids = answers
+        val processedAnswers = answers
+                .filter { it.accepted }
+                .take(3)
+
+        val ids = processedAnswers
                 .map { it.questionId.toString() }
                 .joinToString(separator = ";")
 
         val questionsListModel = questionService.getQuestionById(ids)
 
         return questionsListModel
                 .map { questionListModel: QuestionListModel? ->
-                    addTitlesToAnswers(answers, questionListModel?.items ?: emptyList()) }
+                    addTitlesToAnswers(processedAnswers, questionListModel?.items ?: emptyList()) }
     }
 
     private fun addTitlesToAnswers(answers: List<Answer>, questions: List<Question>) : List<AnswerViewModel> {
@@ -58,10 +62,6 @@ class UserRepository(
         val favorites = favoritesModel.items
                 .take(3)
 
-        val answers = answersModel
-                .filter { it.accepted }
-                .take(3)
-
-        return DetailsModel(questions, answers, favorites)
+        return DetailsModel(questions, answersModel, favorites)
     }
 }
