Parse location.href with an anchor for IE #1049
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -193,7 +196,8 @@ | |||
| if (!settings.crossDomain) { | |||
| urlAnchor = document.createElement('a') | |||
| urlAnchor.href = settings.url | |||
| settings.crossDomain = (window.location.protocol + '//' + window.location.host) !== (urlAnchor.protocol + '//' + urlAnchor.host) | |||
| urlAnchor.href = urlAnchor.href | |||
There was a problem hiding this comment.
You know, that explanation could have gone in the commit message instead of as a screenshot in a line note ;) http://mislav.uniqpath.com/2014/02/hidden-documentation/
There was a problem hiding this comment.
I can open another PR for a comment if you'd like 😄
mislav
added a commit
that referenced
this pull request
Dec 12, 2014
Parse location.href with an anchor for IE
|
Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1046. It turns out that IE always adds the port to
window.location.host, but not toa.host. This doesn't show up in tests because they are run on port 3000, so the port is always present ina.hosttoo.