Skip to content

Remove master branch #4466

Closed
Closed
@normanmaurer

Description

@normanmaurer
Member

After talking with @Scottmitch and also with @nmittler I would like to propose "dropping" current master and so not release any new 5.0 version for now.

The major change of using a ForkJoinPool increases complexity and has not
demonstrated a clear performance benefit. Also keeping all the branches in sync is quite some work without a real need for it as there is nothin in current master which I think justifies a new major release.

Things that we should investigate to prepare for this change:

  • Deprecate exceptionCaught in ChannelHandler, only expose it in ChannelInboundHandler
  • Expose EventExecutorChooser from MultithreadEventExecutorGroup to allow the user more flexibility to choose next EventLoop
  • Add another method to be able to send user events both ways in the pipeline. (Possibility of firing user event in outbound direction. #4378)

Please chime in here and let me / us hear any concerns.

Activity

normanmaurer

normanmaurer commented on Nov 11, 2015

@normanmaurer
MemberAuthor
normanmaurer

normanmaurer commented on Nov 11, 2015

@normanmaurer
MemberAuthor

Also I should have mentioned that we should create a new branch from current master that we keep for "backup" reasons. So we can port code if the need arise later.

trustin

trustin commented on Nov 11, 2015

@trustin
Member

+1. I'd like to keep the handler type hierarchy simplification for later cherry-pick (?) though.

blucas

blucas commented on Nov 11, 2015

@blucas
Contributor

A few questions:

  • So what do you propose creating exactly, for example where would these changes (deprecating exceptionCaught, exposing EventExecutorChooser, etc.) be applied - 4.1, 4.2, or a new 5.0 branch?
  • If I remember correctly, 5.0 merged ChannelInboundHandler and ChannelOutboundHandler as well as introducing messageReceived as a replacement for channelRead0. What would happen to these changes?
  • Will all features/improvements currently applied to master be ported to this new release? Obviously HTTP/2 was ported to 4.1, just wondering if there is anything else sitting on master that would need attention.
ninja-

ninja- commented on Nov 11, 2015

@ninja-

That's a bit sad but I would support this change D: wasn't the major feature of 5.0 fixed eventloop migrations or something like that?

Scottmitch

Scottmitch commented on Nov 11, 2015

@Scottmitch
Member

So what do you propose creating exactly, for example where would these changes (deprecating exceptionCaught, exposing EventExecutorChooser, etc.) be applied - 4.1, 4.2, or a new 5.0 branch?

@blucas - Unless there are objections I think the proposal is to apply these changes to 4.1. The discussion revolves around there not being enough API changes/core features to justify maintaining a different fork. Any deprecated methods/interfaces would also be marked accordingly in 4.0.

If I remember correctly, 5.0 merged ChannelInboundHandler and ChannelOutboundHandler as well as introducing messageReceived as a replacement for channelRead0. What would happen to these changes?

Are you thinking of 4.1 SimpleChannelInboundHandler.channelRead0 vs 5.0 SimpleChannelInboundHandler.messageReceived? In 4.1 I guess we would keep channelRead0 to stay API compatible with 4.0

Will all features/improvements currently applied to master be ported to this new release? Obviously HTTP/2 was ported to 4.1, just wondering if there is anything else sitting on master that would need attention.

That is the intention. If you know of any please call them out :) We will rename the "master" branch so nothing will be lost if we forget/miss something.

normanmaurer

normanmaurer commented on Nov 13, 2015

@normanmaurer
MemberAuthor

@blucas what @Scottmitch said.

normanmaurer

normanmaurer commented on Nov 13, 2015

@normanmaurer
MemberAuthor

@ninja- event loop migration works in 4.0 as well.

Scottmitch

Scottmitch commented on Nov 24, 2015

@Scottmitch
Member

@normanmaurer - Also as a reminder we should revisit deprecated items in 4.1. If things have been deprecated in 4.1 in favor of a change in 5.0, we may want to un-deprecate these items.

Scottmitch

Scottmitch commented on Nov 24, 2015

@Scottmitch
Member

@normanmaurer - For example AUTO_CLOSE channel option may be a candidate.

trustin

trustin commented on Dec 6, 2015

@trustin
Member

Meanwhile, let me change the default branch from 'master' to '4.1'.

normanmaurer

normanmaurer commented on Dec 6, 2015

@normanmaurer
MemberAuthor

Thanks! Will take care of the rest once back from vacation

Am 06.12.2015 um 07:02 schrieb Trustin Lee notifications@github.com:

Meanwhile, let me change the default branch from 'master' to '4.1'.


Reply to this email directly or view it on GitHub.

He-Pin

He-Pin commented on Dec 6, 2015

@He-Pin
Contributor

As Netty In Action covers 4.x,I think this should be fine.

29 remaining items

wxyjuly

wxyjuly commented on Jan 16, 2018

@wxyjuly

come on , waiting for next time updated

niancheng

niancheng commented on Jan 29, 2018

@niancheng

mark

FreedomTrip

FreedomTrip commented on Apr 27, 2018

@FreedomTrip

ok

yschimke

yschimke commented on Nov 14, 2018

@yschimke
Contributor
shihongwei

shihongwei commented on Aug 16, 2019

@shihongwei

mark

shallwetalkge

shallwetalkge commented on Aug 31, 2021

@shallwetalkge

mark

SolarisNeko

SolarisNeko commented on May 31, 2023

@SolarisNeko

What direction will netty 5.x consider to improve performance?
Will you consider the follow-up Java cooperation program (Virtual Thread) ?

niancheng

niancheng commented on May 31, 2023

@niancheng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @trustin@yschimke@normanmaurer@He-Pin@blucas

      Issue actions

        Remove master branch · Issue #4466 · netty/netty