Closed
Description
After talking with @Scottmitch and also with @nmittler I would like to propose "dropping" current master and so not release any new 5.0 version for now.
The major change of using a ForkJoinPool increases complexity and has not
demonstrated a clear performance benefit. Also keeping all the branches in sync is quite some work without a real need for it as there is nothin in current master which I think justifies a new major release.
Things that we should investigate to prepare for this change:
- Deprecate
exceptionCaught
inChannelHandler
, only expose it inChannelInboundHandler
- Expose
EventExecutorChooser
fromMultithreadEventExecutorGroup
to allow the user more flexibility to choose nextEventLoop
- Add another method to be able to send user events both ways in the pipeline. (Possibility of firing user event in outbound direction. #4378)
Please chime in here and let me / us hear any concerns.
Metadata
Metadata
Assignees
Type
Projects
Relationships
Development
No branches or pull requests
Activity
normanmaurer commentedon Nov 11, 2015
/cc @trustin @nmittler @Scottmitch @ejona86 @louiscryan
normanmaurer commentedon Nov 11, 2015
Also I should have mentioned that we should create a new branch from current master that we keep for "backup" reasons. So we can port code if the need arise later.
trustin commentedon Nov 11, 2015
+1. I'd like to keep the handler type hierarchy simplification for later cherry-pick (?) though.
blucas commentedon Nov 11, 2015
A few questions:
exceptionCaught
, exposingEventExecutorChooser
, etc.) be applied - 4.1, 4.2, or a new 5.0 branch?ChannelInboundHandler
andChannelOutboundHandler
as well as introducingmessageReceived
as a replacement forchannelRead0
. What would happen to these changes?ninja- commentedon Nov 11, 2015
That's a bit sad but I would support this change D: wasn't the major feature of 5.0 fixed eventloop migrations or something like that?
Scottmitch commentedon Nov 11, 2015
@blucas - Unless there are objections I think the proposal is to apply these changes to 4.1. The discussion revolves around there not being enough API changes/core features to justify maintaining a different fork. Any deprecated methods/interfaces would also be marked accordingly in 4.0.
Are you thinking of 4.1 SimpleChannelInboundHandler.channelRead0 vs 5.0 SimpleChannelInboundHandler.messageReceived? In 4.1 I guess we would keep channelRead0 to stay API compatible with 4.0
That is the intention. If you know of any please call them out :) We will rename the "master" branch so nothing will be lost if we forget/miss something.
normanmaurer commentedon Nov 13, 2015
@blucas what @Scottmitch said.
normanmaurer commentedon Nov 13, 2015
@ninja- event loop migration works in 4.0 as well.
Scottmitch commentedon Nov 24, 2015
@normanmaurer - Also as a reminder we should revisit deprecated items in 4.1. If things have been deprecated in 4.1 in favor of a change in 5.0, we may want to un-deprecate these items.
Scottmitch commentedon Nov 24, 2015
@normanmaurer - For example
AUTO_CLOSE
channel option may be a candidate.trustin commentedon Dec 6, 2015
Meanwhile, let me change the default branch from 'master' to '4.1'.
normanmaurer commentedon Dec 6, 2015
Thanks! Will take care of the rest once back from vacation
He-Pin commentedon Dec 6, 2015
As Netty In Action covers 4.x,I think this should be fine.
29 remaining items
RingBuffer implementation + usage on WriteBuffer
wxyjuly commentedon Jan 16, 2018
come on , waiting for next time updated
niancheng commentedon Jan 29, 2018
mark
FreedomTrip commentedon Apr 27, 2018
ok
yschimke commentedon Nov 14, 2018
https://github.com/netty/netty/projects/1
fuzhengwei commentedon Aug 9, 2019
netty demo for 4.1
https://bugstack.cn/index.php/category/netty%E4%B8%93%E9%A2%98/
shihongwei commentedon Aug 16, 2019
mark
abcdelf commentedon Jul 20, 2021
https://bugstack.cn/itstack-demo-netty/itstack-demo-netty.html
链接也更新一下呐
shallwetalkge commentedon Aug 31, 2021
mark
SolarisNeko commentedon May 31, 2023
What direction will netty 5.x consider to improve performance?
Will you consider the follow-up Java cooperation program (Virtual Thread) ?
niancheng commentedon May 31, 2023