-
-
Notifications
You must be signed in to change notification settings - Fork 16.1k
Remove master branch #4466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also I should have mentioned that we should create a new branch from current master that we keep for "backup" reasons. So we can port code if the need arise later. |
+1. I'd like to keep the handler type hierarchy simplification for later cherry-pick (?) though. |
A few questions:
|
That's a bit sad but I would support this change D: wasn't the major feature of 5.0 fixed eventloop migrations or something like that? |
@blucas - Unless there are objections I think the proposal is to apply these changes to 4.1. The discussion revolves around there not being enough API changes/core features to justify maintaining a different fork. Any deprecated methods/interfaces would also be marked accordingly in 4.0.
Are you thinking of 4.1 SimpleChannelInboundHandler.channelRead0 vs 5.0 SimpleChannelInboundHandler.messageReceived? In 4.1 I guess we would keep channelRead0 to stay API compatible with 4.0
That is the intention. If you know of any please call them out :) We will rename the "master" branch so nothing will be lost if we forget/miss something. |
@blucas what @Scottmitch said. |
@ninja- event loop migration works in 4.0 as well. |
@normanmaurer - Also as a reminder we should revisit deprecated items in 4.1. If things have been deprecated in 4.1 in favor of a change in 5.0, we may want to un-deprecate these items. |
@normanmaurer - For example |
Meanwhile, let me change the default branch from 'master' to '4.1'. |
Thanks! Will take care of the rest once back from vacation
|
As Netty In Action covers 4.x,I think this should be fine. |
master branch was rename to master_deprecated. Changes only need to go to 4.0 and 4.1 now. |
Woot! thanks @normanmaurer! |
For existing 5.x user, do you recommend to change back to use 4.x or I can still use 5.x? What's the recommend way now |
Use 4.0 or 4.1
|
@normanmaurer this change will break TChannel-JAVA and all TChannel-JAVA users. |
@ShanniLi again just use netty 4.0 which works on android |
@ShanniLi 5.0 was alpha so you should expect breakage. |
@normanmaurer @trustin: Many Many Thanks! Kan |
Mark and support |
come on , waiting for next time updated |
mark |
ok |
netty demo for 4.1 |
mark |
mark |
What direction will netty 5.x consider to improve performance? |
您好!您的来信我已经收到,我会尽快查阅并回复您的!
|
After talking with @Scottmitch and also with @nmittler I would like to propose "dropping" current master and so not release any new 5.0 version for now.
The major change of using a ForkJoinPool increases complexity and has not
demonstrated a clear performance benefit. Also keeping all the branches in sync is quite some work without a real need for it as there is nothin in current master which I think justifies a new major release.
Things that we should investigate to prepare for this change:
exceptionCaught
inChannelHandler
, only expose it inChannelInboundHandler
EventExecutorChooser
fromMultithreadEventExecutorGroup
to allow the user more flexibility to choose nextEventLoop
Please chime in here and let me / us hear any concerns.
The text was updated successfully, but these errors were encountered: