Skip to content

internal/repl is exposed without --expose-internals flag #3393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott opened this issue Oct 16, 2015 · 3 comments
Closed

internal/repl is exposed without --expose-internals flag #3393

Trott opened this issue Oct 16, 2015 · 3 comments
Assignees
@vkurchatkin
Labels
repl Issues and PRs related to the REPL subsystem.

Comments

@Trott
Copy link
Member

Trott commented Oct 16, 2015

Every other module in lib/internal is not available via require() without the --expose-internals flag but internal/repl is.
@Trott Trott added the repl Issues and PRs related to the REPL subsystem. label Oct 16, 2015
@vkurchatkin vkurchatkin self-assigned this Oct 16, 2015
@targos
Copy link
Member

targos commented Oct 16, 2015

Ref: 0450ce7

node/lib/module.js

Lines 276 to 277 in 9148114

// REPL is a special case, because it needs the real require.
if (request === 'internal/repl' || request === 'repl') {

@Fishrock123
Copy link
Contributor

cc @chrisdickinson Are you able to give some context here?

@evanlucas
Copy link
Contributor

This was fixed in ee72ee7.

Just tested on v5.2.0 and confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vkurchatkin vkurchatkin

Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@evanlucas @Trott @Fishrock123 @targos @vkurchatkin