test: fork child node processes #1151
Conversation
| @@ -9,7 +9,7 @@ node_js: | |||
| - '8' | |||
| - '6' | |||
| before_install: | |||
| - if [ "$TRAVIS_BRANCH" == "master" ]; then echo "//registry.npmjs.org/:_authToken=\${NPM_TOKEN}" > .npmrc; fi | |||
| - if [ "$TRAVIS_BRANCH" == "master" ]; then export _authToken=$NPM_TOKEN; fi | |||
There was a problem hiding this comment.
@remy had to do this to get it to build
heisian
changed the title
|
booyakashah! |
|
👍
…On Wed, 6 Dec 2017, 22:52 Tim, ***@***.***> wrote:
booyakashah!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1151 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAA1hN7cp3TXrPAuP6JHr7e2_n0-i1Hzks5s9xpUgaJpZM4Q4mnk>
.
|
|
Cool. Looking forward to merging it! |
|
I'm just waiting on another PR to be finished and I'll merge this in. |
|
Can you merge this commit into your branch? It should fix the npm install problem properly now and will allow me to merge without having to edit your code. |
|
Damn, just hit the first issue that says using Try running |
| @@ -82,7 +83,17 @@ function run(options) { | |||
| }); | |||
| } | |||
|
|
|||
| child = spawn.apply(null, spawnArgs); | |||
| if (executable === 'node') { | |||
| var forkArgs = cmd.args.slice(1); | |||
There was a problem hiding this comment.
Out of interest - why is this .slice(1)?
| @@ -82,7 +83,17 @@ function run(options) { | |||
| }); | |||
| } | |||
|
|
|||
| child = spawn.apply(null, spawnArgs); | |||
| if (executable === 'node') { | |||
There was a problem hiding this comment.
I'm also adding cmd.args[0].indexOf('-') === -1 && to this line so that spawns if there's a node argument being passed.
it blends