Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize .. in tuple (struct) patterns #36843

Merged
merged 1 commit into from Nov 8, 2016
Merged

Stabilize .. in tuple (struct) patterns #36843

merged 1 commit into from Nov 8, 2016

Conversation

petrochenkov
Copy link
Contributor

I'd like to nominate .. in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203

Closes #33627
r? @nikomatsakis

@brson brson added I-nominated T-lang Relevant to the language team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Sep 30, 2016
@nikomatsakis
Copy link
Contributor

cc @rust-lang/lang -- thoughts on stabilizing Foo(x, ..)? <-- @petrochenkov that's what this is about, right?

@petrochenkov
Copy link
Contributor Author

Foo(x, ..)? <-- that's what this is about, right?

Right

@nrc
Copy link
Member

nrc commented Oct 4, 2016

I'd be happy for the tracking issue to be in FCP this cycle. I don't feel any pressure to fast track stabilisation.

@petrochenkov
Copy link
Contributor Author

I'd be happy for the tracking issue to be in FCP this cycle.

Let's assume the FCP starts now5 days ago then?
(I also posted a note on stabilization a couple of cycles ago #33627 (comment), but nobody finally-commented on it, I should probably make such notes more officially looking in the future.)

@aturon
Copy link
Member

aturon commented Oct 4, 2016

Proposing FCP for stabilizing this cycle:

@rfcbot fcp merge

@nikomatsakis
Copy link
Contributor

@petrochenkov I left a comment, seems good to me

@aturon aturon mentioned this pull request Oct 4, 2016
Closed
@rfcbot
Copy link

rfcbot commented Oct 4, 2016 •
edited

FCP proposed with disposition to merge. Review requested from:

No concerns currently listed.
See this document for info about what commands tagged team members can give me.

@aturon
Copy link
Member

aturon commented Oct 4, 2016

Oops, I got confused and thought this was the tracking issue rather than the PR. Sorry!

@rfcbot cancel

@bors
Copy link
Contributor

bors commented Oct 7, 2016

☔ The latest upstream changes (presumably #36945) made this pull request unmergeable. Please resolve the merge conflicts.

@rfcbot
Copy link

rfcbot commented Oct 13, 2016

All relevant subteam members have reviewed. No concerns remain.

@rfcbot
Copy link

rfcbot commented Oct 20, 2016

It has been one week since all blocks to the FCP were resolved.

@nikomatsakis
Copy link
Contributor

@petrochenkov FCP is over, care to rebase?

@petrochenkov
Copy link
Contributor Author

Rebased.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 8, 2016

📌 Commit 74bb594 has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Nov 8, 2016

⌛ Testing commit 74bb594 with merge 722c687...

bors added a commit that referenced this pull request Nov 8, 2016
@bors
Auto merge of #36843 - petrochenkov:dotstab, r=nikomatsakis
722c687 
Stabilize `..` in tuple (struct) patterns

I'd like to nominate `..` in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203

Closes #33627
r? @nikomatsakis
@jseyfried
Copy link
Contributor

@bors retry force

@bors
Copy link
Contributor

bors commented Nov 8, 2016

⌛ Testing commit 74bb594 with merge 38a959a...

bors added a commit that referenced this pull request Nov 8, 2016
@bors
Auto merge of #36843 - petrochenkov:dotstab, r=nikomatsakis
38a959a 
Stabilize `..` in tuple (struct) patterns

I'd like to nominate `..` in tuple and tuple struct patterns for stabilization.
This feature is a relatively small extension to existing stable functionality and doesn't have known blockers.
The feature first appeared in Rust 1.10 6 months ago.
An example of use: #36203

Closes #33627
r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Nov 8, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nikomatsakis
Pushing 38a959a to master...

@bors bors merged commit 74bb594 into rust-lang:master Nov 8, 2016
@bors bors mentioned this pull request Nov 8, 2016
Merged
@petrochenkov petrochenkov deleted the dotstab branch March 16, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
relnotes Marks issues that should be documented in the release notes of the next release. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@petrochenkov @nikomatsakis @nrc @aturon @rfcbot @bors @jseyfried @brson