Stabilize rfc 1506 - Clarified ADT Kinds #41145
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
matthewjasper
force-pushed
the
stabilize-relaxed-adts
branch
from
15caa61
to
f90ccd3
Compare
|
Thanks! We'll try to get someone to review your PR soon! r? @pnkfelix |
|
Wait, can I merge this before the docs land? |
|
(It certainly looks fine; this is more a process issue.) |
|
/cc @steveklabnik ? |
arielb1
added
S-waiting-on-review
|
r? @arielb1. I'll be looking at this shortly. |
|
I think we should be waiting for the docs to land to avoid this being split across 1.17/1.18. but r=me after that. |
|
☔ The latest upstream changes (presumably #41411) made this pull request unmergeable. Please resolve the merge conflicts. |
matthewjasper
force-pushed
the
stabilize-relaxed-adts
branch
from
5217489
to
3e59b34
Compare
matthewjasper
force-pushed
the
stabilize-relaxed-adts
branch
from
3e59b34
to
5fc2522
Compare
|
☔ The latest upstream changes (presumably #39999) made this pull request unmergeable. Please resolve the merge conflicts. |
matthewjasper
force-pushed
the
stabilize-relaxed-adts
branch
from
5fc2522
to
8927212
Compare
|
☔ The latest upstream changes (presumably #41464) made this pull request unmergeable. Please resolve the merge conflicts. |
matthewjasper
force-pushed
the
stabilize-relaxed-adts
branch
from
8927212
to
8a3ea01
Compare
|
☔ The latest upstream changes (presumably #41437) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Still waiting for the docs to land on reference. |
arielb1
added
S-waiting-on-team
|
Still waiting for the docs to land on reference. But there's a light at the end of the tunnel:
|
|
@arielb1 was that @steveklabnik you were quoting there? What's the current status of this? |
|
This is a real easy feature to land for 1.19, just need to resolve this docs pr in the next two weeks. |
|
@brson I have wanted to get on it but haven't; IMHO, since we have the PR, this can land. Generally it's
so we don't churn feature flags in the docs. given that this is the only thing blocking, we should land this, and I will make it a priority to get this reviewed. I didn't realize it was considered blocking here. |
|
☔ The latest upstream changes (presumably #42165) made this pull request unmergeable. Please resolve the merge conflicts. |
matthewjasper
force-pushed
the
stabilize-relaxed-adts
branch
from
839d148
to
354ba2b
Compare
src/libsyntax/feature_gate.rs
Outdated
| @@ -1291,6 +1287,11 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> { | |||
| ast::ExprKind::InPlace(..) => { | |||
| gate_feature_post!(&self, placement_in_syntax, e.span, EXPLAIN_PLACEMENT_IN); | |||
| } | |||
| <<<<<<< HEAD | |||
matthewjasper
force-pushed
the
stabilize-relaxed-adts
branch
2 times, most recently
from
b8750cf
to
1573142
Compare
matthewjasper
force-pushed
the
stabilize-relaxed-adts
branch
from
1573142
to
6627ef2
Compare
|
Given @steveklabnik's comment #41145 (comment) |
|
📌 Commit 6627ef2 has been approved by |
…henkov Stabilize rfc 1506 - Clarified ADT Kinds Closes #35626 Documentation: - [ ] Reference rust-lang/reference#37 - [ ] Book? - [ ] Rust by example?
|
☀️ Test successful - status-appveyor, status-travis |
Closes #35626
Documentation: