Skip to content

Make use of @EnableDiscoveryClient optional. #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spencergibb opened this issue Jun 8, 2017 · 2 comments
Closed

Make use of @EnableDiscoveryClient optional. #218

spencergibb opened this issue Jun 8, 2017 · 2 comments
Assignees
@ryanjbaxter
Labels
enhancement
Milestone
1.3.0.RC1

Comments

@spencergibb
Copy link
Member

More devs are putting it on a profile enabled configuration. In all impls it just creates a marker bean and then auto configuration kicks in. I don't see why this couldn't be just auto configuration and properties. Would blend better with sidecar proxies. @dsyer, @ryanjbaxter
@dsyer
Copy link
Contributor

dsyer commented Jun 9, 2017

I think you are right: it's time to pack this one off to autoconfig. Edgware?

@spencergibb spencergibb added this to the 1.3.0.M1 milestone Jun 13, 2017
@ryanjbaxter ryanjbaxter modified the milestones: 1.3.0.M2, 1.3.0.M1 Aug 22, 2017
@ryanjbaxter
Copy link
Contributor

Should we continue to support @EnableDiscoveryClient(autoRegister=false)? To me it seems to make more sense, and be more consistent, if we had a property that disabled auto registration rather than keep @EnableDiscoveryClient around for just that purpose. Thoughts?

@ryanjbaxter ryanjbaxter mentioned this issue Aug 23, 2017
Merged
@ryanjbaxter ryanjbaxter self-assigned this Aug 23, 2017
@spencergibb spencergibb mentioned this issue Aug 24, 2017
Open
This was referenced Aug 31, 2017
Closed
Closed
Closed
@eacdy eacdy mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanjbaxter ryanjbaxter

Labels
enhancement
Projects
None yet
Milestone
1.3.0.RC1
Development

No branches or pull requests
3 participants
@dsyer @ryanjbaxter @spencergibb