Michael Osipov said:

I am highly interested in this. Pool 1.x and 2.x are not compatible and different package names.

Anindya Chatterjee said:

Any update on this issue? Any road map for the implementation?

If not yet, I'll work on it and create PR.

Rob Winch said:

anidotnet Thanks for the offer for making a PR! We would greatly appreciate it. Please ensure any PR that is submitted is passive so as not to break existing users.

Anindya Chatterjee said:

I have submitted the PR as promised.

[https://github.com//pull/33]

Anindya Chatterjee said:

Any update please about merging the PR?

Rob Winch said:

This is resolved in master

@spring-issuemaster This issue still exists with latest Ldap core 2.3.2 release. When this will be fixed?

I too have this issue right now with spring boot 2.2.3
The whole reason for using spring-ldap was the idea of support for ldap pool, but unfortunately there is this bug.
Is anyone working on fixing this issue?

I too have this issue right now with spring boot 2.2.3
The whole reason for using spring-ldap was the idea of support for ldap pool, but unfortunately there is this bug.
Is anyone working on fixing this issue?

@snytkine @salmanVD commons-pool2 is working fine for me with Spring LDAP Core version 2.3.2. One thing you have to consider is that there are two classes, one is for commons-pool and the other is for commons-pool2.

For commons-pool 1.x use the class:
org.springframework.ldap.pool.factory.PoolingContextSource

For commons-pool 2.x use class:
org.springframework.ldap.pool2.factory.PooledContextSource

Note that the first one is in the pool subpackage while the second one on the pool2 subpackage. Also, the name of the commons-pool2 class starts with Pooled while the commons-pool 1 starts with Pooling

The Spring LDAP documentation does not mention this difference in the Pooling Support section, I found out about this by looking at the code of spring-ldap-core.

Sample code:

...
import org.springframework.ldap.pool2.factory.PoolConfig;
import org.springframework.ldap.pool2.factory.PooledContextSource;
import org.springframework.ldap.pool2.validation.DefaultDirContextValidator;
...
@Bean
public ContextSource contextSource() {
    
    LdapContextSource contextSource = new LdapContextSource();
    contextSource.setUrl("ldap://my.ldap.server.com:389");
    contextSource.setBase("o=myorg.com");
    contextSource.setUserDn("uid=someUserId,cn=mycn,o=myorg.com");
    contextSource.setPassword("super-secret-password");
    contextSource.afterPropertiesSet();

    // Configures Spring LDAP pooling for LDAP connections
    PoolConfig poolConfig = new PoolConfig();
    
    /* Objects will be validated before being borrowed from the pool. If the object fails to validate,
    it will be dropped from the pool, and an attempt to borrow another will be made. */
    poolConfig.setTestOnBorrow(true);

    /*The limit on the number of object instances allocated by the pool (checked out or idle), per key.
    When the limit is reached, the sub-pool is said to be exhausted. A negative value indicates no limit.*/
    poolConfig.setMaxTotalPerKey(-1);

    /*The maximum number of active connections of each type (read-only|read-write) that can remain idle
    in the pool, without extra ones being released, or non-positive for no limit.*/
    poolConfig.setMaxIdlePerKey(-1);

    PooledContextSource pcs = new PooledContextSource(poolConfig);
    pcs.setContextSource(contextSource);
    pcs.setDirContextValidator(new DefaultDirContextValidator());

    TransactionAwareContextSourceProxy contextSourceProxy = new TransactionAwareContextSourceProxy(pcs);

    return contextSourceProxy;
}