Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Embedded UnboundID LDAP Server support #399

Closed
wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

Previous to this commit, the only provider for embedded ldap server was
apacheds. Now, unboundid can be used as a option for testing purpose.

See gh-386

@rwinch
Copy link
Member

rwinch commented Apr 14, 2016

@eddumelendez Thanks for the PR! Like using ApacheDS, we are going to need to get this added to Spring IO in order to merge this. Can you create a ticket at https://github.com/spring-io/platform/issues and mention me on it?

@eddumelendez
Copy link
Contributor Author

@rwinch Sure. Done.

Previous to this commit, the only provider for embedded ldap server was
apacheds. Now, unboundid can be used as a option for testing purpose.

See spring-projectsgh-386
@eddumelendez
Copy link
Contributor Author

@rwinch since spring-io managed unboundid:ldap-sdk as a dependency and spring-ldap is running under spring-io:2.1.0-SNAPSHOT. This PR will be in a major release, right?

@rwinch rwinch added this to the 2.2.0.RC1 milestone May 23, 2016
@rwinch
Copy link
Member

rwinch commented May 23, 2016

@eddumelendez Yes. I plan to put it in the next release. Thanks for reminding me to update this issue

@pivotal-issuemaster
Copy link

@eddumelendez Please sign the Contributor License Agreement!

@eddumelendez
Copy link
Contributor Author

@rwinch signed!

@rwinch rwinch closed this Sep 30, 2016
@rwinch rwinch reopened this Sep 30, 2016
@pivotal-issuemaster
Copy link

@eddumelendez Thank you for signing the Contributor License Agreement!

rwinch pushed a commit that referenced this pull request Sep 30, 2016
* Close ClasspathXmlApplicationContext
* Change apacheDsDependencies to test vs optional
* Formatting

Issue: gh-399
rwinch pushed a commit that referenced this pull request Sep 30, 2016
* Remove copied deprecated methods
* Close ClasspathXmlApplicationContext
* Change apacheDsDependencies to test vs optional
* Formatting

Issue: gh-399
@rwinch
Copy link
Member

rwinch commented Sep 30, 2016

Thanks for the PR! This is merged via 594c361 and I gave it some Polish in 1a5bead

@rwinch rwinch closed this Sep 30, 2016
@rwinch rwinch self-assigned this Sep 30, 2016
@rwinch rwinch changed the title Add unboundid embedded ldap server Add Embedded UnboundID LDAP Server support Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants