Skip to content

computed has an error #3612

New issue
New issue
Closed
Closed
computed has an error#3612
@draguo

Description

@draguo
draguo
opened on Sep 7, 2016

Vue.js version

1.0.26

Demo

jsfiddle
or
test

result

click the button then the result will has error
left is ios 9.3.4 iphone 6 plus right is android phone
result

has error

ios 9.3.3 and 9.3.4 iphone 6s plus or iphone 5s

no error

ios 8.2 iphone 6 ，some android phone，PC chrome

from #3545

Activity

posva

posva commented on Sep 7, 2016

@posva
posva
on Sep 7, 2016
Member

I don't have a device to test it. Does this https://jsfiddle.net/bzyyvafg/ work?

sqal

sqal commented on Sep 7, 2016

@sqal
sqal
on Sep 7, 2016 · edited by sqal
Contributor

@posva Yeah it works I just wanted to post the same example. For in breaks the app because OP doesn't use hasOwnProperty check and is looping over inherited properties which you definitely want to avoid. I recommend to start using Eslint and follow good JS practices - https://github.com/airbnb/javascript#iterators-and-generators

posva

posva commented on Sep 7, 2016

@posva
posva
on Sep 7, 2016
Member

Then I'm closing this 🙂

posva
closed this as completedon Sep 7, 2016
draguo

draguo commented on Sep 8, 2016

@draguo
draguo
on Sep 8, 2016
Author

it works. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @posva@sqal@draguo

        Issue actions
          computed has an error · Issue #3612 · vuejs/vue