Skip to content

Instantly share code, notes, and snippets.

@erica

erica/Approach1.swift

Last active August 25, 2021 18:08
Show Gist options
  • Save erica/d300f8dac3baa7d40aadd18bd1902172 to your computer and use it in GitHub Desktop.
Save erica/d300f8dac3baa7d40aadd18bd1902172 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
Approach1.swift
// Returns `URL?`
public enum SocketEndPoint: String {
case eventSocket = "http://nowhere.com/events"
case liveSocket = "http://nowhere.com/live"
public var url: URL? {
return URL(string: self.rawValue)
}
}
// Uses Implicitly Unwrapped Optional in initializer
// Will crash on malformed URL
public struct WebSocket {
public let url: URL
public init(url: URL!) {
self.url = url
}
}
// His initializer
fileprivate init() {
self.eventSocket = WebSocket(url: SocketEndPoint.events.url))
self.liveSocket = WebSocket(url: SocketEndPoint.live.url))
self.eventSocket.delegate = self
self.liveSocket.delegate = self
}
Raw
Approach2.swift
extension URL {
/// Non-optional initializer with better fail output
public init(safeString string: String) {
guard let instance = URL(string: string) else {
fatalError("Unconstructable URL: \(string)")
}
self = instance
}
}
// Returns `URL`
public enum SocketEndPoint: String {
case eventSocket = "http://nowhere.com/events"
case liveSocket = "http://nowhere.com/live"
public var url: URL {
return URL(safeString: self.rawValue)
}
}
// Vanilla `URL` initialization
public struct WebSocket {
public let url: URL
public init(url: URL) {
self.url = url
}
}
// His initializer
fileprivate init() {
self.eventSocket = WebSocket(url: SocketEndPoint.events.url))
self.liveSocket = WebSocket(url: SocketEndPoint.live.url))
self.eventSocket.delegate = self
self.liveSocket.delegate = self
}
Raw
Approach3.swift
// Returns `URL` with guided fail
public enum SocketEndPoint: String {
case eventSocket = "http://nowhere.com/events"
case liveSocket = "http://nowhere.com/live"
public var url: URL? {
guard let url = URL(string: self.rawValue) else {
fatalError("Unconstructable URL: \(self.rawValue)")
}
return url
}
}
// Uses normal initializer
public struct WebSocket {
public let url: URL
public init(url: URL) {
self.url = url
}
}
// His initializer
fileprivate init() {
self.eventSocket = WebSocket(url: SocketEndPoint.events.url))
self.liveSocket = WebSocket(url: SocketEndPoint.live.url))
self.eventSocket.delegate = self
self.liveSocket.delegate = self
}
@delight-by
Copy link

delight-by commented Jan 29, 2017 •
edited

How about that?

enum SocketEndPoint {
     // if you want customized error
    static var events: URL = url("http://nowhere.com/events")

    // but I'd go with this one, as you can always validate SocketEndPoint in tests and go runtime checks free after that
    static var live = URL(string: "http://nowhere.com/live")! 

    private static func url(_ string: String) -> URL {
        guard let url = URL(string: string) else {
            fatalError("Unconstructable URL: \(string)")
        }
        return url
    }
}

SocketEndPoint.events
SocketEndPoint.live
  • less noise at call sites
  • stored, instead of reevaluated on every access
  • can be extended
  • if you need more than just urls (e.g. SocketEndPoint.events.metadata), you can have structs in place of URL's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment