Feature - Task Metrics #1492
Merged
Feature - Task Metrics #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -154,6 +183,8 @@ public struct DownloadResponse<Value> { | |||
| /// The timeline of the complete lifecycle of the request. | |||
| public let timeline: Timeline | |||
|
|
|||
| var _metrics: AnyObject? | |||
There was a problem hiding this comment.
Why is this AnyObject and not URLSessionTaskMetrics?
There was a problem hiding this comment.
Just so the internal variable didn't need be behind an availability check?
There was a problem hiding this comment.
Yep...you can't store a URLSessionTaskMetrics as a stored property b/c it's not available on the older OS's. This is the only valid workaround I've found to the problem yet. It's nasty, but it does work.
There was a problem hiding this comment.
You can't put the whole stored property behind an availability check?
|
Looks good. |
|
Awesome, thanks @jshier. I'm going to go ahead and move this through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the awesome new
URLSessionTaskMetricstatistical tracking. This is essentially what we always wanted theTimelineto be, but we didn't have access to the same internal APIs to compute all these data points. Thanks Apple!This shouldn't be a difficult feature to build, but it most definitely was due to the complexity of compiling against 4 platforms with only three of the latest actually supporting new APIs. Therefore, I had to get pretty creative with the new
Responseprotocol and extension in combination withAnyObjectabstraction while moving the metrics through the various objects.Overall, I'm VERY happy with how this turned out. I wish it wasn't so complicated to support so many platforms, but unfortunately, it is. I abstracted the complexity away into the single
Responseprotocol and implementation, so that certainly helps isolate all the platform complexity to a single area.