Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with pod spec lint for library that has dependencies #5213

Closed
astruts opened this issue Apr 28, 2016 · 4 comments
Closed

Issue with pod spec lint for library that has dependencies #5213

astruts opened this issue Apr 28, 2016 · 4 comments
Labels
s1:awaiting input Waiting for input from the original author

Comments

@astruts
Copy link

astruts commented Apr 28, 2016

Hello, I am using Cocoapods 1.0.0 beta-8 and trying to lint a static library that has a dependency on another library, during lint I get the next error:

error: include of non-modular header inside framework module ‘name of the library’

I’ve created a simple project with pod create and have the same issue over there.
https://github.com/astruts/LRLib
The project is a pure Objective-C project and the dependency is also a pure Objective C library (no Swift is used).
Please take a look on source files of this project.
@lrozenblyum
Copy link

It's rather an annoying issue.
Does anyone know a workaround?

Even when I try to create a pod that depends on a simple library JKBigInteger it also doesn't pass the validation with the same message 'error: include of non-modular header inside framework module ‘name of the library’.

@segiddins
Copy link
Member

If it needs to be a static library, lint with --use-libraries.

@segiddins segiddins added the s1:awaiting input Waiting for input from the original author label Apr 28, 2016
@lrozenblyum
Copy link

lrozenblyum commented Apr 29, 2016 •
edited

Hello! Your suggestion about --use-libraries was really great ! It solved the issue of linting.

I have a few questions.

  1. Can the pod spec lint documentation be extended to clearly state need of usage of this flag for this case?
  2. Will it be possible to push our library to trunk if it doesn't pass pod spec lint but passes pod spec lint --use-libraries?
  3. maybe what we are doing was wrong and untypical in iOS world (because of lack of experience), should we create another kind of library to pass the lint validation without additional flags?

Thank you for help & feedback!

@segiddins
Copy link
Member

pod trunk push has the --use-libraries flag, which is documented in https://guides.cocoapods.org/terminal/commands.html#pod_trunk_push. (And no, what you're doing isn't necessarily wrong, it just happens to not work with the default of dynamic frameworks installation by the linter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s1:awaiting input Waiting for input from the original author
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lrozenblyum @segiddins @astruts