New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix copy multiple .xcassets resource error #3358
Conversation
@AliSoftware please take a look at this? |
This PR seems good. The travis failure is only due to integration specs not being rebuilt with the fixed script, we should probably fix/rebuild them along the way but I won't have time today, so postponing the merge until then. (except if @mrackwitz do rebuild them again today 😉) |
I think both versions fail if there are spaces in the file name. My alternate version is this:
It works for me but I've not done much testing beyond my one project that was failing. (I can create a pull request if you like but it might be easier to include in this one?) |
I had spaces in my file name because of the auto created watch kit extension. @sdarlington fixes the issue for me. |
i can fix it. |
How about using
|
@bonkey Looks good (though I've not tried it). Didn't know about the -d option for |
18e2d38
to
e27c431
Compare
It needs some adjustments as it looks like XCASSET_FILES in a loop is a local copy only |
@bonkey seems can use |
Found at least sth what works in my case:
|
I still prefer @bonkey or my solution -- I think they're a lot clearer -- but if it works I'll be happy(!). |
I have same issue with large project containing multiple XCassets and App extension.
My solution was to use @sdarlington fix: changing line 172 to Here's step by step for those who has same problem:
|
Allow support for pods with xcasset bundles using `:path`. Closes CocoaPods#1549 Closes CocoaPods#3384 Closes CocoaPods#3358
if a project has multiple .xcassets folder, the copy_resources.sh will occur a error.
like this:
error: Failed to read file attributes for "/Users/Candyan/Joyshare/Mobile/Arrietty/Arrietty/Images.xcassets /Users/Candyan/Joyshare/Mobile/Arrietty/Arrietty/test.xcassets" Failure Reason: No such file or directory
i found the problem in copy_resources.sh
'while read line' commond will read all result rather than one line of result.