Map properties to multiple JSON key paths #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - (NSDictionary *)JSONDictionary __attribute((deprecated("Replaced by -serializeToJSONDictionary:"))); | ||
| - (NSDictionary *)JSONDictionary __attribute__((deprecated("Replaced by -serializeToJSONDictionary:"))); | ||
|
|
||
| - (NSString *)JSONKeyPathForPropertyKey:(NSString *)key __attribute__((unavailable("Replaced by -JSONKeyPathsByPropertyKey"))); |
There was a problem hiding this comment.
@paulyoung This may be relevant to #264
| // Returns a dictionary mapping property keys to JSON key paths (as strings) or | ||
| // NSNull values. | ||
| // Returns a dictionary mapping property keys to one or multiple JSON key paths | ||
| // (as strings or arrays of strings). |
There was a problem hiding this comment.
Since this is getting more complicated, can you document an example on this method?
|
Can you add a test for associating multiple JSON key paths with multiple components to one property, as well? |
|
Let me know what you think of this example |
| // Any keys omitted will not participate in JSON serialization. | ||
| // | ||
| // Returns a dictionary mapping property keys to JSON key paths (as strings) or | ||
| // NSNull values. | ||
| // For example: |
There was a problem hiding this comment.
This should be titled "Examples" per TomDoc style.
|
🚈 |
|
🚄 |
|
🚋 |
jspahrsummers
added a commit
that referenced
this pull request
Mar 18, 2014
Map properties to multiple JSON key paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263