Make sure mouse position is not a factor for .click() in IE 10

Polymer · Aug 5, 2015 · 1a2fb4d · 1a2fb4d
1 parent 1eef1a7
commit 1a2fb4d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/standard/gestures.html b/src/standard/gestures.html
@@ -124,8 +124,8 @@
       var bcr = t.getBoundingClientRect();
       // use page x/y to account for scrolling
       var x = ev.pageX, y = ev.pageY;
-      return (x >= bcr.left && x <= bcr.right) &&
-        (y >= bcr.top && y <= bcr.bottom);
+      // ev is a synthetic click if the position is outside the bounding box of the target
+      return !((x >= bcr.left && x <= bcr.right) && (y >= bcr.top && y <= bcr.bottom));
     }
     return false;
   }

diff --git a/test/unit/gestures.html b/test/unit/gestures.html
@@ -54,6 +54,8 @@
       });
 
       test('HTMLElement.click triggers tap', function() {
+        // put the element off screen to prevent x/y weirdness from .click()
+        app.style.cssText = 'position: absolute; left: -1000px; top: -1000px;';
         // make a mousedown *very* far away to tickle the distance check
         var ev = new CustomEvent('mousedown');
         ev.clientX = 1e8;