Make sure mouse position is not a factor for .click() in IE 10

dfreedm · dfreedm · commit 1a2fb4dcea04 · 2015-08-05T15:02:40.000-07:00
diff --git a/src/standard/gestures.html b/src/standard/gestures.html
@@ -124,8 +124,8 @@
       var bcr = t.getBoundingClientRect();
       // use page x/y to account for scrolling
       var x = ev.pageX, y = ev.pageY;
-      return (x >= bcr.left && x <= bcr.right) &&
-        (y >= bcr.top && y <= bcr.bottom);
+      // ev is a synthetic click if the position is outside the bounding box of the target
+      return !((x >= bcr.left && x <= bcr.right) && (y >= bcr.top && y <= bcr.bottom));
     }
     return false;
   }
diff --git a/test/unit/gestures.html b/test/unit/gestures.html
@@ -54,6 +54,8 @@
       });
 
       test('HTMLElement.click triggers tap', function() {
+        // put the element off screen to prevent x/y weirdness from .click()
+        app.style.cssText = 'position: absolute; left: -1000px; top: -1000px;';
         // make a mousedown *very* far away to tickle the distance check
         var ev = new CustomEvent('mousedown');
         ev.clientX = 1e8;

Original file line number	Diff line number	Diff line change
`@@ -124,8 +124,8 @@`
`124`	`124`	`var bcr = t.getBoundingClientRect();`
`125`	`125`	`// use page x/y to account for scrolling`
`126`	`126`	`var x = ev.pageX, y = ev.pageY;`
`127`		`- return (x >= bcr.left && x <= bcr.right) &&`
`128`		`- (y >= bcr.top && y <= bcr.bottom);`
	`127`	`+ // ev is a synthetic click if the position is outside the bounding box of the target`
	`128`	`+ return !((x >= bcr.left && x <= bcr.right) && (y >= bcr.top && y <= bcr.bottom));`
`129`	`129`	`}`
`130`	`130`	`return false;`
`131`	`131`	`}`