Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom property resolver tripping over some selectors? #1938

Closed
sjmiles opened this issue Jun 22, 2015 · 1 comment
Closed

custom property resolver tripping over some selectors? #1938

sjmiles opened this issue Jun 22, 2015 · 1 comment
Assignees
@sorvell
Labels
p1

Comments

@sjmiles
Copy link
Contributor

sjmiles commented Jun 22, 2015

Given a story-card element, local styles like:

 `#story-card .story-content {`

are confusing some part of the style engine.

http://jsbin.com/zozute/edit?html,output

Looks like using an id with the same text as the element tag is confusing a regex somewhere.
sorvell pushed a commit that referenced this issue Jun 24, 2015
Fixes #1938: make host selector not tripped up by id, attr, or pseudo…
ab8c285 
… properties

Fixes #1874, #1761: maintain static declarations within declarations that contain custom properties
Fixes #1927: make custom property parser able to see property endings of ; or \n or end token.
@sorvell sorvell mentioned this issue Jun 24, 2015
Merged
@sorvell
Copy link
Contributor

sorvell commented Jun 25, 2015

Fixed via #1948

@sorvell sorvell closed this as completed Jun 25, 2015
@sorvell sorvell mentioned this issue Jun 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sorvell @sjmiles @kevinpschaaf