Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array mutations can fail when arguments to splice are a string #2062

Closed
kevinpschaaf opened this issue Jul 10, 2015 · 0 comments
Closed

Array mutations can fail when arguments to splice are a string #2062

kevinpschaaf opened this issue Jul 10, 2015 · 0 comments
Assignees
@kevinpschaaf
Labels
p1

Comments

@kevinpschaaf
Copy link
Member

Repro here: http://jsbin.com/faqetabada/2/edit?html,output

Should just parseInt on args before notifying splices.
@kevinpschaaf kevinpschaaf self-assigned this Jul 13, 2015
kevinpschaaf added a commit that referenced this issue Jul 24, 2015
@kevinpschaaf
Allow array API's accept string & negative args. Fixes #2062.
2ef0ae0 
Brings the API more in line with native splice, etc.
sorvell pushed a commit that referenced this issue Jul 25, 2015
Merge pull request #2140 from Polymer/2062-kschaaf-array-args
720f2c0 
Allow array API's accept string & negative args. Fixes #2062.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinpschaaf kevinpschaaf

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinpschaaf