Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymer.dom can call some shady dom code when running shadow dom #2341

Closed
sorvell opened this issue Aug 22, 2015 · 4 comments
Closed

Polymer.dom can call some shady dom code when running shadow dom #2341

sorvell opened this issue Aug 22, 2015 · 4 comments
Assignees
@rictic
Labels
p1

Comments

@sorvell
Copy link
Contributor

sorvell commented Aug 22, 2015

For example, the dom mutation methods call shady dom code paths. Instead they should be routed to the native dom methods: appendChild, insertBefore, removeChild, replaceChild, cloneNode.
@sorvell sorvell added the p1 label Aug 22, 2015
@sorvell sorvell self-assigned this Aug 22, 2015
@sorvell
Copy link
Contributor Author

sorvell commented Aug 22, 2015

NOTE: #2338 was submitted to correct this issue, but I think we should just branch these methods earlier instead.

@sorvell sorvell assigned rictic and unassigned sorvell Aug 22, 2015
@sorvell
Copy link
Contributor Author

sorvell commented Aug 22, 2015

@rictic Would you mind taking a look at my PR for this #2342 and testing it out. Feel free to merge it if it looks ok. Thanks!

@rictic
Copy link
Contributor

rictic commented Aug 22, 2015

Running tests

@rictic
Copy link
Contributor

rictic commented Aug 22, 2015

The tests that were failing before are passing now. I'll do a full run and merge this tonight if all's well.

@rictic rictic mentioned this issue Aug 22, 2015
Closed
rictic added a commit that referenced this issue Aug 22, 2015
@rictic
Merge pull request #2342 from Polymer/fix-2341
5605634 
Fixes #2341: branch Polymer.dom to use native dom methods under Shado…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rictic rictic

Labels
p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rictic @sorvell