Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon with hash #364

Closed
victorwpbastos opened this issue Jun 29, 2016 · 5 comments
Closed

Favicon with hash #364

victorwpbastos opened this issue Jun 29, 2016 · 5 comments

Comments

@victorwpbastos
Copy link
Contributor

https://github.com/ampedandwired/html-webpack-plugin/blob/master/index.js#L410

Says that with option hash: true, It would add a hash to favicons. After several tests, I realized that javascript and css files contains a hash, but favicons don't. Maybe is this a bug?

My config:

new HtmlWebpackPlugin({
    filename: 'index.html',
    template: 'index.html',
    favicon: 'favicon.ico',
    hash: true
})
@jantimon
Copy link
Owner

Hm don't know why but you could use the https://github.com/jantimon/favicons-webpack-plugin - it will generate a hashed filename if needed.

@victorwpbastos
Copy link
Contributor Author

Why was this issue closed? The error still persists.

@misha-erm
Copy link

Is there any update on this?

@olsonpm
Copy link

olsonpm commented Dec 11, 2017

I think it's important to note that even if the hash did work for favicon, it is a compilation hash and not a content hash. The hash is also appended via query string as opposed to appending to the file name. Neither of these qualities are ideal for caching so I suggest users either create a PR fix or find an alterntative solution (that's what I'm doing). This library has been great for generating the html and I'm going to leave its purpose at that.

@lock
Copy link

lock bot commented May 31, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants